IndexedDB: chrome-side changes for permission check from shared worker

IndexedDB: chrome-side changes for permission check from shared worker

https://bugs.webkit.org/show_bug.cgi?id=79954 is the webkit side.

BUG=116344
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124618

[dgrogan, 2012-03-01 01:44:56]

Michael, could you review this?

This was mostly copy-pasting from the stuff that was already there.

[michaeln, 2012-03-01 05:55:25]

yup, i'll look tommorow

On 2012/03/01 01:44:56, dgrogan wrote:
> Michael, could you review this?
> 
> This was mostly copy-pasting from the stuff that was already there.

[michaeln, 2012-03-01 20:46:08]

chrome-side looks straight forward enough, i'll take a look at the webkit-side

not something for this CL, but i wonder if we can consolidate some of this
'allow' plumbing such that instead of having virtually identical parallel paths,
we have one code path that perhaps carries a parameter indicating the 'type' of
thing to be allowed?

http://codereview.chromium.org/9557009/diff/1014/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/9557009/diff/1014/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:963: // Record access to file
system for potential display in UI.
comment should say "indexed db"

[michaeln, 2012-03-01 21:17:55]

after looking at the webkit-side, lgtm

[dgrogan, 2012-03-02 00:41:11]

https://chromiumcodereview.appspot.com/9557009/diff/1014/chrome/browser/chrom...
File chrome/browser/chrome_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/9557009/diff/1014/chrome/browser/chrom...
chrome/browser/chrome_content_browser_client.cc:963: // Record access to file
system for potential display in UI.
On 2012/03/01 20:46:08, michaeln wrote:
> comment should say "indexed db"

Done.

[commit-bot: I haz the power, 2012-03-02 00:42:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9557009/5002

[commit-bot: I haz the power, 2012-03-02 00:43:15]

Presubmit check for 9557009-5002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/mock_content_browser_client.h,content/browser/worker_host/worker_process_host.cc,content/common/worker_messages.h,content/browser/worker_host/worker_process_host.h,content/worker/websharedworkerclient_proxy.h,content/worker/websharedworkerclient_proxy.cc,content/browser/mock_content_browser_client.cc,content/public/browser/content_browser_client.h

Presubmit checks took 2.0s to calculate.

[jam, 2012-03-02 00:43:43]

content owners lgtm

[commit-bot: I haz the power, 2012-03-02 00:45:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9557009/5002

[commit-bot: I haz the power, 2012-03-02 07:42:51]

Change committed as 124618