Move certificate verification tests from X509CertificateTest to CertVerifyProcTest

Move certificate verification tests from X509CertificateTest to CertVerifyProcTest

This is patch 3 of N for http://crbug.com/114343

BUG=114343
TEST=net_unittests:CertVerifyProc*

[Ryan Sleevi, 2012-03-06 02:24:23]

wtc: More batch copying. This didn't trigger git's copy detection.

This depends on http://codereview.chromium.org/9476035/ and
http://codereview.chromium.org/9584041/

Once those changes are reviewed and land, I'll rebase this on an SVN copy so
that cert_verify_proc_unittest.cc shows as a copy for
x509_certificate_unittest.cc, so that history is preserved.

[wtc, 2012-03-06 23:26:54]

LGTM.

http://codereview.chromium.org/9553014/diff/1/net/base/cert_verify_proc_unitt...
File net/base/cert_verify_proc_unittest.cc (right):

http://codereview.chromium.org/9553014/diff/1/net/base/cert_verify_proc_unitt...
net/base/cert_verify_proc_unittest.cc:42: MultiThreadedCertVerifier::VerifyProc*
GetSystemVerifier() {

I saw this function in your other CL.  Perhaps this should
be a public method of MultiThreadedCertVerifier?

Perhaps we should shorten MultiThreadedCertVerifier::VerifyProc
to CertVerifyProc?

http://codereview.chromium.org/9553014/diff/1/net/base/test_certificate_data.h
File net/base/test_certificate_data.h (right):

http://codereview.chromium.org/9553014/diff/1/net/base/test_certificate_data....
net/base/test_certificate_data.h:8: static const char nistSPKIHash[] =

Nit: this constant should be named with a k: kNistSPKIHash.

If you want this CL to be pure copying of code, it's fine
to not rename this.

[Ryan Sleevi, 2012-03-10 03:30:56]

Patchset 3 shows the simplification by SystemCertVerifyProc.

http://codereview.chromium.org/9553014/diff/1/net/base/cert_verify_proc_unitt...
File net/base/cert_verify_proc_unittest.cc (right):

http://codereview.chromium.org/9553014/diff/1/net/base/cert_verify_proc_unitt...
net/base/cert_verify_proc_unittest.cc:42: MultiThreadedCertVerifier::VerifyProc*
GetSystemVerifier() {
On 2012/03/06 23:26:54, wtc wrote:
> 
> I saw this function in your other CL.  Perhaps this should
> be a public method of MultiThreadedCertVerifier?
> 
> Perhaps we should shorten MultiThreadedCertVerifier::VerifyProc
> to CertVerifyProc?

This has now been addressed by SystemCertVerifyProc.

http://codereview.chromium.org/9553014/diff/1/net/base/test_certificate_data.h
File net/base/test_certificate_data.h (right):

http://codereview.chromium.org/9553014/diff/1/net/base/test_certificate_data....
net/base/test_certificate_data.h:8: static const char nistSPKIHash[] =
On 2012/03/06 23:26:54, wtc wrote:
> 
> Nit: this constant should be named with a k: kNistSPKIHash.
> 
> If you want this CL to be pure copying of code, it's fine
> to not rename this.

I'll fix it in a follow-up.

[wtc, 2012-03-14 22:04:11]

Patch set 4 LGTM.