Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 9553007: Remove a unused parameter in the Linux FilePathWatcher implementation. (Closed)

Created:
8 years, 9 months ago by Lei Zhang
Modified:
8 years, 9 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove a unused parameter in the Linux FilePathWatcher implementation. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126359

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M base/files/file_path_watcher_linux.cc View 1 6 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
8 years, 9 months ago (2012-03-06 00:48:49 UTC) #1
Lei Zhang
ping?
8 years, 9 months ago (2012-03-09 21:24:04 UTC) #2
Mattias Nissler (ping if slow)
Sorry for the delay, I was on vacation. LGTM, and thanks for the cleanup. http://codereview.chromium.org/9553007/diff/3001/base/files/file_path_watcher_linux.cc ...
8 years, 9 months ago (2012-03-12 08:50:04 UTC) #3
Lei Zhang
http://codereview.chromium.org/9553007/diff/3001/base/files/file_path_watcher_linux.cc File base/files/file_path_watcher_linux.cc (right): http://codereview.chromium.org/9553007/diff/3001/base/files/file_path_watcher_linux.cc#newcode337 base/files/file_path_watcher_linux.cc:337: // 'is_directory' set in the event masks. As a ...
8 years, 9 months ago (2012-03-12 20:42:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9553007/7001
8 years, 9 months ago (2012-03-12 20:42:57 UTC) #5
Lei Zhang
Hmm, CQ's going to fail without an OWNER.
8 years, 9 months ago (2012-03-12 20:43:31 UTC) #6
Lei Zhang
Oh but wait, base/files has its own OWNERS.
8 years, 9 months ago (2012-03-12 20:47:32 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 9 months ago (2012-03-12 22:30:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9553007/7001
8 years, 9 months ago (2012-03-12 22:33:10 UTC) #9
commit-bot: I haz the power
Try job failure for 9553007-7001 (retry) on win_rel for steps "browser_tests, check_deps". It's a second ...
8 years, 9 months ago (2012-03-13 00:43:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9553007/7001
8 years, 9 months ago (2012-03-13 07:10:44 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 08:34:00 UTC) #12
Change committed as 126359

Powered by Google App Engine
This is Rietveld 408576698