Issue 9553003: Delete HostDelegate objects instead of HostImpl objects to avoid leaking the former.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9553003: Delete HostDelegate objects instead of HostImpl objects to avoid leaking the former. (Closed)

Created:
8 years, 9 months ago by Ami GONE FROM CHROMIUM

Modified:
8 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, pam+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Delete HostDelegate objects instead of HostImpl objects to avoid leaking the former. BUG=116744 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125105

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	content/browser/browser_child_process_host_impl.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

jam: I *think* this is what http://crrev.com/118516 made necessary, but I'm completely unfamiliar with this ...

8 years, 9 months ago (2012-03-06 01:00:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9553003/1

8 years, 9 months ago (2012-03-06 01:14:24 UTC) #3

Change committed as 125105

Expand Messages | Collapse Messages