[Sync] Move dependency on Chrome switches from SyncNotifierFactory

[Sync] Move dependency on Chrome switches from SyncNotifierFactory

Move all command-line parsing code into sync_backend_host.cc and
sync_listen_notifications.cc.

BUG=113723
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125325

[akalin, 2012-03-06 01:09:57]

+zea for review

[Nicolas Zea, 2012-03-06 19:00:58]

http://codereview.chromium.org/9550009/diff/6001/chrome/browser/sync/glue/syn...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/9550009/diff/6001/chrome/browser/sync/glue/syn...
chrome/browser/sync/glue/sync_backend_host.cc:235: notifier::NotifierOptions
ParseNotifierOptions(
Can this be in it's own file within glue/ (so sync_listen_notifications can
include and reuse it)?

http://codereview.chromium.org/9550009/diff/6001/chrome/browser/sync/glue/syn...
chrome/browser/sync/glue/sync_backend_host.cc:254: DVLOG(1) << "Trying SSL/TCP
port before XMPP port for notifications.";
dvlog_if (here and below)

[akalin, 2012-03-06 22:27:57]

PTAL

http://codereview.chromium.org/9550009/diff/6001/chrome/browser/sync/glue/syn...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/9550009/diff/6001/chrome/browser/sync/glue/syn...
chrome/browser/sync/glue/sync_backend_host.cc:235: notifier::NotifierOptions
ParseNotifierOptions(
On 2012/03/06 19:00:58, nzea wrote:
> Can this be in it's own file within glue/ (so sync_listen_notifications can
> include and reuse it)?

Ideally, sync_listen_notifications wouldn't depend on glue either.

I think it's better to have separate implementations, so they can diverge. 
sync_listen_notifications already diverges in that it doesn't have a
--invalidate-xmpp-token switch (it doesn't make sense, since token is already
specified on the command-line), it uses different switches, and different
logging levels.  And probably in the future it may diverge more.

http://codereview.chromium.org/9550009/diff/6001/chrome/browser/sync/glue/syn...
chrome/browser/sync/glue/sync_backend_host.cc:254: DVLOG(1) << "Trying SSL/TCP
port before XMPP port for notifications.";
On 2012/03/06 19:00:58, nzea wrote:
> dvlog_if (here and below)

Done.  Also fixed sync_listen_notifications to use LOG_IF.

[Nicolas Zea, 2012-03-06 22:29:42]

lgtm

[commit-bot: I haz the power, 2012-03-07 02:28:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/9550009/13001

[commit-bot: I haz the power, 2012-03-07 02:28:31]

Can't apply patch for file chrome/browser/sync/glue/sync_backend_host.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/sync/glue/sync_backend_host.cc
Hunk #1 FAILED at 35.
Hunk #2 succeeded at 226 (offset 2 lines).
Hunk #3 succeeded at 286 (offset 2 lines).
Hunk #4 succeeded at 303 (offset 2 lines).
1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/sync/glue/sync_backend_host.cc.rej

[commit-bot: I haz the power, 2012-03-07 02:30:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/9550009/8007

[commit-bot: I haz the power, 2012-03-07 04:41:55]

Change committed as 125325