Pre-login should not set cookies and log the user in of cookies are not

Pre-login should not set cookies and log the user in of cookies are not
enabled for google accounts.

BUG=None
TEST=Create a new profile.  Go to content settings and block all sites from
setting data.  Alternatively, block only the https://accounts.google.com from
setting data.  Now connect the profile a google account.  The browser should
not be logged (i.e. going to gmail should not show the inbox).  Looking at
all cookie and site data should show no cookies for accounts.google.com.

[jochen (gone - plz use gerrit), 2012-03-01 08:27:58]

lgtm with comment addressed

https://chromiumcodereview.appspot.com/9549026/diff/1/chrome/browser/signin/s...
File chrome/browser/signin/signin_manager.cc (right):

https://chromiumcodereview.appspot.com/9549026/diff/1/chrome/browser/signin/s...
chrome/browser/signin/signin_manager.cc:129: if
(cookie_settings->IsReadingCookieAllowed(GURL(kGoogleAccountsUrl),
IsSettingCookieAllowed is enough. Also, please use kGoogleAccountsUrl for both
arguments

[Roger Tawa OOO till Jul 10th, 2012-03-01 16:53:36]

Thanks Jochen.  Comments addressed, changes uploaded.  Will commit shortly.

http://codereview.chromium.org/9549026/diff/1/chrome/browser/signin/signin_ma...
File chrome/browser/signin/signin_manager.cc (right):

http://codereview.chromium.org/9549026/diff/1/chrome/browser/signin/signin_ma...
chrome/browser/signin/signin_manager.cc:129: if
(cookie_settings->IsReadingCookieAllowed(GURL(kGoogleAccountsUrl),
On 2012/03/01 08:27:58, jochen wrote:
> IsSettingCookieAllowed is enough. Also, please use kGoogleAccountsUrl for both
> arguments

Done.  I added a check against null pointer too.

[commit-bot: I haz the power, 2012-03-01 21:29:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/9549026/4002

[commit-bot: I haz the power, 2012-03-01 23:29:31]

Change committed as 124527