Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 9549009: Allows tab dragging when maximized on aura. To fix it I made it so (Closed)

Created:
8 years, 9 months ago by sky
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Allows tab dragging when maximized on aura. To fix it I made it so that you can drag a maximized window when tab dragging and no constraints are imposed on the window. Only when the mouse is released do we do anything. This only handles the multiple tab case, if you've selected all the tabs in a maximized window we won't detach. BUG=116074 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124385

Patch Set 1 #

Patch Set 2 : Fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -28 lines) Patch
M ash/wm/property_util.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/wm/property_util.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/window_resizer.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ash/wm/window_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 3 chunks +8 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 4 chunks +29 lines, -8 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 1 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
8 years, 9 months ago (2012-02-29 23:36:12 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-02-29 23:42:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9549009/1
8 years, 9 months ago (2012-02-29 23:50:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9549009/4002
8 years, 9 months ago (2012-03-01 04:43:45 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 07:52:46 UTC) #5
Change committed as 124385

Powered by Google App Engine
This is Rietveld 408576698