Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 9547009: Factor out the shared parts of IPC channel reading. (Closed)

Created:
8 years, 9 months ago by brettw
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Factor out the shared parts of IPC channel reading. This adds a new class+file ChannelReader that is responsible for management of the common parts of IPC channel reading. The existing platform-specific ChannelImpl classes derive from this and supply platform-specific reading features via virtual classes. This is to reduce code duplication between the Windows and Posix implementations of Channel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125597

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -250 lines) Patch
M ipc/ipc.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ipc/ipc_channel_posix.h View 7 chunks +10 lines, -49 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 11 chunks +15 lines, -80 lines 0 comments Download
A ipc/ipc_channel_reader.h View 1 chunk +105 lines, -0 lines 0 comments Download
A ipc/ipc_channel_reader.cc View 1 chunk +93 lines, -0 lines 0 comments Download
M ipc/ipc_channel_win.h View 4 chunks +10 lines, -33 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 5 chunks +7 lines, -77 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
8 years, 9 months ago (2012-03-06 00:34:12 UTC) #1
Elliot Glaysher
Removing copypastad code? lgtm
8 years, 9 months ago (2012-03-06 02:55:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9547009/1
8 years, 9 months ago (2012-03-07 17:35:17 UTC) #3
commit-bot: I haz the power
Try job failure for 9547009-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-07 17:51:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9547009/12001
8 years, 9 months ago (2012-03-08 06:11:37 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-08 12:30:30 UTC) #6
Change committed as 125597

Powered by Google App Engine
This is Rietveld 408576698