Support detaching/attaching panels via inter-strip drags.

chrome/browser/ui/panels/detached_panel_strip.cc

Index: chrome/browser/ui/panels/detached_panel_strip.cc
diff --git a/chrome/browser/ui/panels/detached_panel_strip.cc b/chrome/browser/ui/panels/detached_panel_strip.cc
index acc89a82b5d1b4be30e0eaa9fe95ba9f244da1aa..a178a7529b4ffe5919204f1075cdd26fa0d68be8 100644
--- a/chrome/browser/ui/panels/detached_panel_strip.cc
+++ b/chrome/browser/ui/panels/detached_panel_strip.cc
@@ -33,10 +33,14 @@ void DetachedPanelStrip::RefreshLayout() {
   NOTIMPLEMENTED();
 }
 
-void DetachedPanelStrip::AddPanel(Panel* panel) {
+void DetachedPanelStrip::AddPanel(Panel* panel,
+                                  PositioningMask positioning_mask) {
+  // positioning_mask is ignored since the detached panel is free-floating.
   DCHECK_NE(this, panel->panel_strip());
   panel->set_panel_strip(this);
   panels_.insert(panel);
+
+  panel->SetAlwaysOnTop(false);
 }
 
 void DetachedPanelStrip::RemovePanel(Panel* panel) {
@@ -91,27 +95,46 @@ bool DetachedPanelStrip::CanShowPanelAsActive(const Panel* panel) const {
   return true;
 }
 
+void DetachedPanelStrip::SavePanelPlacement(Panel* panel) {
+  DCHECK(!saved_panel_placement_.panel);
+  saved_panel_placement_.panel = panel;
+  saved_panel_placement_.position = panel->GetBounds().origin();
+}
+
+void DetachedPanelStrip::RestorePanelToSavedPlacement() {
+  DCHECK(saved_panel_placement_.panel);
+
+  gfx::Rect new_bounds(saved_panel_placement_.panel->GetBounds());
+  new_bounds.set_origin(saved_panel_placement_.position);
+  saved_panel_placement_.panel->SetPanelBounds(new_bounds);
+
+  DiscardSavedPanelPlacement();
+}
+
+void DetachedPanelStrip::DiscardSavedPanelPlacement() {
+  DCHECK(saved_panel_placement_.panel);
+  saved_panel_placement_.panel = NULL;
+}
+
 bool DetachedPanelStrip::CanDragPanel(const Panel* panel) const {
   // All detached panels are draggable.
   return true;
 }
 
-void DetachedPanelStrip::StartDraggingPanel(Panel* panel) {
+void DetachedPanelStrip::StartDraggingPanelWithinStrip(Panel* panel) {
+  DCHECK(HasPanel(panel));
 }
 
-void DetachedPanelStrip::DragPanel(Panel* panel, int delta_x, int delta_y) {
+void DetachedPanelStrip::DragPanelWithinStrip(Panel* panel,
+                                              int delta_x,
+                                              int delta_y) {
   gfx::Rect new_bounds(panel->GetBounds());
   new_bounds.Offset(delta_x, delta_y);
-  panel->SetPanelBounds(new_bounds);
+  panel->SetPanelBoundsInstantly(new_bounds);

[jennb, 2012/03/12 22:43:00]

Why no animation?

[jianli, 2012/03/13 00:21:40]

When we're dragging a panel via mouse moving, the panel should jump immediately
to the right position without any animation because otherwise the user will see
some kind of artifact images.

 }
 
-void DetachedPanelStrip::EndDraggingPanel(Panel* panel, bool cancelled) {
-  if (cancelled) {
-    gfx::Rect new_bounds(panel->GetBounds());
-    new_bounds.set_origin(
-        panel_manager_->drag_controller()->dragging_panel_original_position());
-    panel->SetPanelBounds(new_bounds);
-  }
+void DetachedPanelStrip::EndDraggingPanelWithinStrip(Panel* panel,
+                                                     bool aborted) {
 }
 
 bool DetachedPanelStrip::HasPanel(Panel* panel) const {