Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7845)

Unified Diff: chrome/browser/ui/panels/overflow_panel_strip.cc

Issue 9546001: Support detaching/attaching panels via inter-strip drags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/overflow_panel_strip.cc
diff --git a/chrome/browser/ui/panels/overflow_panel_strip.cc b/chrome/browser/ui/panels/overflow_panel_strip.cc
index ce4505b2fb97569d08373c9efc0c9444a06cb0c2..145b96e951dd753e1f5a3156872c8da7ab363242 100644
--- a/chrome/browser/ui/panels/overflow_panel_strip.cc
+++ b/chrome/browser/ui/panels/overflow_panel_strip.cc
@@ -190,20 +190,35 @@ bool OverflowPanelStrip::CanShowPanelAsActive(const Panel* panel) const {
return false;
}
+void OverflowPanelStrip::SavePanelPlacement(Panel* panel) {
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::RestorePanelToSavedPlacement() {
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::DiscardSavedPanelPlacement() {
+ NOTREACHED();
+}
+
bool OverflowPanelStrip::CanDragPanel(const Panel* panel) const {
// All overflow panels are not draggable.
return false;
}
-void OverflowPanelStrip::StartDraggingPanel(Panel* panel) {
+void OverflowPanelStrip::StartDraggingPanelWithinStrip(Panel* panel) {
NOTREACHED();
}
-void OverflowPanelStrip::DragPanel(Panel* panel, int delta_x, int delta_y) {
+void OverflowPanelStrip::DragPanelWithinStrip(Panel* panel,
+ int delta_x,
+ int delta_y) {
NOTREACHED();
}
-void OverflowPanelStrip::EndDraggingPanel(Panel* panel, bool cancelled) {
+void OverflowPanelStrip::EndDraggingPanelWithinStrip(Panel* panel,
+ bool aborted) {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698