Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4648)

Unified Diff: chrome/browser/ui/panels/overflow_panel_strip.cc

Issue 9546001: Support detaching/attaching panels via inter-strip drags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/overflow_panel_strip.cc
diff --git a/chrome/browser/ui/panels/overflow_panel_strip.cc b/chrome/browser/ui/panels/overflow_panel_strip.cc
index 934d71857f9359290249de2ee8269942428b3651..e955c4e28d35a154263bf49e609c2e38da9699e7 100644
--- a/chrome/browser/ui/panels/overflow_panel_strip.cc
+++ b/chrome/browser/ui/panels/overflow_panel_strip.cc
@@ -185,20 +185,39 @@ bool OverflowPanelStrip::CanShowPanelAsActive(const Panel* panel) const {
return false;
}
+void OverflowPanelStrip::SavePanelPlacement(Panel* panel) {
jennb 2012/03/03 02:19:33 nit: (and probably overkill) but feels like this i
jianli 2012/03/07 19:14:31 Will add DraggableStrip if we have more strips lat
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::LoadSavedPanelPlacement() {
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::DiscardSavedPanelPlacement() {
+ NOTREACHED();
+}
+
bool OverflowPanelStrip::CanDragPanel(const Panel* panel) const {
// All overflow panels are not draggable.
return false;
}
-void OverflowPanelStrip::StartDraggingPanel(Panel* panel) {
+void OverflowPanelStrip::StartDraggingPanelLocally(Panel* panel) {
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::DragPanelLocally(Panel* panel,
+ int delta_x,
+ int delta_y) {
NOTREACHED();
}
-void OverflowPanelStrip::DragPanel(Panel* panel, int delta_x, int delta_y) {
+void OverflowPanelStrip::EndDraggingPanelLocally(Panel* panel, bool cancelled) {
NOTREACHED();
}
-void OverflowPanelStrip::EndDraggingPanel(Panel* panel, bool cancelled) {
+void OverflowPanelStrip::AddDraggingPanel(Panel* panel,
+ const gfx::Point& position) {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698