Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: chrome/browser/ui/panels/panel_titlebar_view_cocoa.h

Issue 9546001: Support detaching/attaching panels via inter-strip drags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_titlebar_view_cocoa.h
diff --git a/chrome/browser/ui/panels/panel_titlebar_view_cocoa.h b/chrome/browser/ui/panels/panel_titlebar_view_cocoa.h
index a93f5b8c231dafb9873a7abb7aa52ff1df10c69f..4c741e43bec10b99906f8fec0ac27e837e610748 100644
--- a/chrome/browser/ui/panels/panel_titlebar_view_cocoa.h
+++ b/chrome/browser/ui/panels/panel_titlebar_view_cocoa.h
@@ -58,7 +58,7 @@ enum PanelDragState {
ScopedCrTrackingArea closeButtonTrackingArea_;
PanelDragState dragState_;
BOOL isDrawingAttention_;
- NSPoint dragStartLocation_;
+ NSPoint dragStartLocation_; // in screen coordinates.
// "Glint" animation is used in "Draw Attention" mode.
scoped_nsobject<RepaintAnimation> glintAnimation_;
scoped_nsobject<NSTimer> glintAnimationTimer_;
@@ -89,10 +89,10 @@ enum PanelDragState {
- (void)didChangeMainWindow:(NSNotification*)notification;
// Helpers to control title drag operation, called from more then one place.
-- (void)startDrag;
+// |mouseLocation| is in screen coordinates.
+- (void)startDrag:(NSPoint)mouseLocation;
- (void)endDrag:(BOOL)cancelled;
-- (void)dragWithDeltaX:(int)deltaX
- deltaY:(int)deltaY;
+- (void)drag:(NSPoint)mouseLocation;
// Update the visibility of settings button.
- (void)updateSettingsButtonVisibility:(BOOL)mouseOverWindow;
@@ -122,10 +122,9 @@ enum PanelDragState {
- (void)simulateCloseButtonClick;
// NativePanelTesting support.
-- (void)pressLeftMouseButtonTitlebar;
+- (void)pressLeftMouseButtonTitlebar:(NSPoint)mouseLocation;
- (void)releaseLeftMouseButtonTitlebar;
-- (void)dragTitlebarDeltaX:(double)delta_x
- deltaY:(double)delta_y;
+- (void)dragTitlebar:(NSPoint)mouseLocation;
- (void)cancelDragTitlebar;
- (void)finishDragTitlebar;

Powered by Google App Engine
This is Rietveld 408576698