Support detaching/attaching panels via inter-strip drags.

chrome/browser/ui/panels/panel_browser_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_view.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "chrome/browser/native_window_notification_source.h"
 #include "chrome/browser/ui/panels/panel.h"
@@ skipping 504 matching lines @@
   if (!mouse_pressed_)
     return false;
   mouse_pressed_ = false;
 
   mouse_dragging_state_ = DRAGGING_ENDED;
   panel_->manager()->EndDragging(cancelled);
   return true;
 }
 
 void PanelBrowserView::SetPanelAppIconVisibility(bool visible) {
+  // The panel should not show app icon in the desktop bar if it is in overflow.

[jennb, 2012/03/08 23:41:09]

Delete. If you need such a comment, it belongs in the place that calls this
method, presumably, the overflow strip.

[jianli, 2012/03/09 21:48:58]

Done.

 #if defined(OS_WIN) && !defined(USE_AURA)
   gfx::NativeWindow native_window = GetNativeHandle();
-  ::ShowWindow(native_window, SW_HIDE);
   int style = ::GetWindowLong(native_window, GWL_EXSTYLE);
+  int new_style = style;
   if (visible)
-    style &= (~WS_EX_TOOLWINDOW);
+    new_style &= (~WS_EX_TOOLWINDOW);
   else
-    style |= WS_EX_TOOLWINDOW;
-  ::SetWindowLong(native_window, GWL_EXSTYLE, style);
-  ::ShowWindow(native_window, SW_SHOWNA);
+    new_style |= WS_EX_TOOLWINDOW;
+  if (style != new_style) {
+    ::ShowWindow(native_window, SW_HIDE);
+    ::SetWindowLong(native_window, GWL_EXSTYLE, new_style);
+    ::ShowWindow(native_window, SW_SHOWNA);
+  }
 #else
   NOTIMPLEMENTED();
 #endif
 }
 
+void PanelBrowserView::SetPanelAlwaysOnTop(bool on_top) {
+  GetWidget()->SetAlwaysOnTop(on_top);
+}
+
 // NativePanelTesting implementation.
 class NativePanelTestingWin : public NativePanelTesting {
  public:
   explicit NativePanelTestingWin(PanelBrowserView* panel_browser_view);
 
  private:
   virtual void PressLeftMouseButtonTitlebar(
       const gfx::Point& mouse_location) OVERRIDE;
   virtual void ReleaseMouseButtonTitlebar() OVERRIDE;
   virtual void DragTitlebar(const gfx::Point& mouse_location) OVERRIDE;
@@ skipping 62 matching lines @@
 }
 
 bool NativePanelTestingWin::IsWindowSizeKnown() const {
   return true;
 }
 
 bool NativePanelTestingWin::IsAnimatingBounds() const {
   return panel_browser_view_->bounds_animator_.get() &&
          panel_browser_view_->bounds_animator_->is_animating();
 }