Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Unified Diff: net/test/test_server_win.cc

Issue 9545019: Add "run_testserver --sync-test" for easy chromiumsync_test.py launching. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/test_server_win.cc
diff --git a/net/test/test_server_win.cc b/net/test/test_server_win.cc
index 07bcee5cb60c31cb846267f1f407ab3e8f865717..dc3dc5380d88056f30f8a46febdd655c6a6caded 100644
--- a/net/test/test_server_win.cc
+++ b/net/test/test_server_win.cc
@@ -84,16 +84,20 @@ bool ReadData(HANDLE read_fd, HANDLE write_fd,
namespace net {
-bool TestServer::LaunchPython(const FilePath& testserver_path) {
+// static
+FilePath TestServer::GetAbsolutePythonCommandPath() {
FilePath python_exe;
if (!PathService::Get(base::DIR_SOURCE_ROOT, &python_exe))
- return false;
+ return FilePath();
python_exe = python_exe
.Append(FILE_PATH_LITERAL("third_party"))
.Append(FILE_PATH_LITERAL("python_26"))
.Append(FILE_PATH_LITERAL("python.exe"));
+ return python_exe;
+}
- CommandLine python_command(python_exe);
+bool TestServer::LaunchPython(const FilePath& testserver_path) {
+ CommandLine python_command(GetAbsolutePythonCommandPath());
python_command.AppendArgPath(testserver_path);
if (!AddCommandLineArguments(&python_command))
return false;

Powered by Google App Engine
This is Rietveld 408576698