Add "run_testserver --sync-test" for easy chromiumsync_test.py launching.

net/test/test_server_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/test_server.h"
 
 #include <poll.h>
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/process_util.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/test/test_timeouts.h"
+#include "net/test/python_utils.h"
 
 namespace {
 
 // Helper class used to detect and kill orphaned python test server processes.
 // Checks if the command line of a process contains |path_string| (the path
 // from which the test server was launched) and |port_string| (the port used by
 // the test server), and if the parent pid of the process is 1 (indicating that
 // it is an orphaned process).
 class OrphanedTestServerFilter : public base::ProcessFilter {
  public:
@@ skipping 59 matching lines @@
     bytes_read += num_bytes;
   }
   return true;
 }
 
 }  // namespace
 
 namespace net {
 
 bool TestServer::LaunchPython(const FilePath& testserver_path) {
+  VLOG(1) << "LaunchPython called with PYTHONPATH = " <<

[Paweł Hajdan Jr., 2012/03/13 17:15:23]

Is this needed?

[tim (not reviewing), 2012/03/15 00:41:40]

Fred asked for this in review, and I think it's useful in the event somebody
wants to run a nearby script (e.g. a test) in the same environment as the test
server, which is the problem we had that motivated this whole patch... I added a
comment.  

+          getenv(kPythonPathEnv);
   CommandLine python_command(FilePath(FILE_PATH_LITERAL("python")));
   python_command.AppendArgPath(testserver_path);
   if (!AddCommandLineArguments(&python_command))
     return false;
 
   int pipefd[2];
   if (pipe(pipefd) != 0) {
     PLOG(ERROR) << "Could not create pipe.";
     return false;
   }
@@ skipping 49 matching lines @@
 
   if (!ParseServerData(server_data)) {
     LOG(ERROR) << "Could not parse server_data: " << server_data;
     return false;
   }
 
   return true;
 }
 
 }  // namespace net