Add "run_testserver --sync-test" for easy chromiumsync_test.py launching.

net/test/test_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/test_server.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 80 matching lines @@
 
   Init(host, document_root);
 }
 
 TestServer::~TestServer() {
   TestRootCerts* root_certs = TestRootCerts::GetInstance();
   root_certs->Clear();
   Stop();
 }
 
+FilePath TestServer::GetTestServerDirectory() {
+  // Get path to python server script.
+  FilePath testserver_dir;
+  if (!PathService::Get(base::DIR_SOURCE_ROOT, &testserver_dir)) {
+    LOG(ERROR) << "Failed to get DIR_SOURCE_ROOT";
+    return FilePath();

[Paweł Hajdan Jr., 2012/03/13 17:15:23]

I don't like potentially ambiguous return types. Make the function return bool
instead (+WARN_UNUSED_RESULT), and return the FilePath via out-parameter.

[tim (not reviewing), 2012/03/15 00:41:40]

Done.

+  }
+
+  testserver_dir = testserver_dir
+      .Append(FILE_PATH_LITERAL("net"))
+      .Append(FILE_PATH_LITERAL("tools"))
+      .Append(FILE_PATH_LITERAL("testserver"));
+  return testserver_dir;
+}
+
 bool TestServer::Start() {
   if (type_ == TYPE_HTTPS) {
     if (!LoadTestRootCert())
       return false;
   }
 
-  // Get path to python server script
-  FilePath testserver_path;
-  if (!PathService::Get(base::DIR_SOURCE_ROOT, &testserver_path)) {
-    LOG(ERROR) << "Failed to get DIR_SOURCE_ROOT";
+  FilePath testserver_path(GetTestServerDirectory());
+  if (testserver_path.empty())
     return false;
-  }
-  testserver_path = testserver_path
-      .Append(FILE_PATH_LITERAL("net"))
-      .Append(FILE_PATH_LITERAL("tools"))
-      .Append(FILE_PATH_LITERAL("testserver"))
-      .Append(FILE_PATH_LITERAL("testserver.py"));
+  testserver_path =
+      testserver_path.Append(FILE_PATH_LITERAL("testserver.py"));
 
   if (!SetPythonPath())
     return false;
 
   if (!LaunchPython(testserver_path))
     return false;
 
   if (!WaitToStart()) {
     Stop();
     return false;
@@ skipping 284 matching lines @@
       command_line->AppendArg(kBulkCipherSwitch + "=3des");
 
     if (https_options_.record_resume)
       command_line->AppendArg("--https-record-resume");
   }
 
   return true;
 }
 
 }  // namespace net