Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: content/browser/cert_store.h

Issue 9545011: Allow CertStore to be mocked by making its method virtual. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert none LGTMed changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cert_store.h
diff --git a/content/browser/cert_store.h b/content/browser/cert_store.h
index f27a75f3a272765029158529603957419ea9c5c9..dd68d1102ea6623a827b437c08f73ccbd375891b 100644
--- a/content/browser/cert_store.h
+++ b/content/browser/cert_store.h
@@ -35,24 +35,25 @@ class CONTENT_EXPORT CertStore : public content::NotificationObserver {
// When all the RenderProcessHosts associated with a cert have exited, the
// cert is removed from the store.
// Note: ids starts at 1.
- int StoreCert(net::X509Certificate* cert, int render_process_host_id);
+ virtual int StoreCert(net::X509Certificate* cert, int render_process_host_id);
// Tries to retrieve the previously stored cert associated with the specified
- // |cert_id|. Returns whether the cert could be found, and, if |cert| is
+ // |cert_id|. Returns whether the cert could be found, and, if |cert| is
// non-NULL, copies it in.
- bool RetrieveCert(int cert_id, scoped_refptr<net::X509Certificate>* cert);
+ virtual bool RetrieveCert(int cert_id,
+ scoped_refptr<net::X509Certificate>* cert);
// content::NotificationObserver implementation.
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ protected:
+ CertStore();
+ virtual ~CertStore();
private:
friend struct DefaultSingletonTraits<CertStore>;
- CertStore();
- virtual ~CertStore();
-
void RegisterForNotification();
// Remove the specified cert from id_to_cert_ and cert_to_id_.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698