Allow CertStore to be mocked by making its method virtual.

Allow CertStore to be mocked by making its method virtual.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124952

[markusheintz_, 2012-03-01 01:46:56]

Could you please review this CL?

This CL would allow me to create a MockCertStore (see
https://chromiumcodereview.appspot.com/9378014) which would make testing much
easier for me.

Originally I did not use a MockCertStore in CL 9378014 which lead to a memory
leak in the unittest.

Thanks a lot

[jam, 2012-03-01 06:13:53]

lgtm, i'm planning on adding an interface around this class anyways for the
Content API

[markusheintz_, 2012-03-02 01:38:39]

Sorry to ping you again for this CL.

I actually need to change one more thing: I need to make
"RemoveCertsForRenderProcesHost" public.

The problem I had was that in CL http://codereview.chromium.org/937801 the test
"HTTPSBadCertificate"(see
http://codereview.chromium.org/9378014/diff/45001/chrome/browser/website_sett...)
triggered a code path where |SSLErrorInfo| tries to retrieve the cert from the
|CertStore| singleton. I have no chance to inject my mock there and if the
CertStore does not contain the cert used in the test the test fails (DCHECK).

I tried using the CertStore singleton, but this cause a memory leak since the
certificates in the CertStore did not get deleted by the destructor. So I tried
to clear the certificate from the CertStore by sending a Notification. But
therefor I need to setup so many object that I do not need in my test. That
seems kind of wrong to me. That's why I though it would be easier to make
"RemoveCertsForRenderProcesHost" public. WDYT?

[commit-bot: I haz the power, 2012-03-05 15:29:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9545011/13001

[markusheintz_, 2012-03-05 15:30:50]

I moved patchset 3 from this CL to a new CL and committed the LGTMed parts.

[commit-bot: I haz the power, 2012-03-05 17:18:20]

Change committed as 124952