Disable storing cookies from URLFetchers that run with a profile's cookie jar.

chrome/browser/autofill/autofill_download.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_download.h"
 
 #include <algorithm>
 #include <ostream>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/browser/autofill/autofill_xml_parser.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/common/url_fetcher.h"
 #include "googleurl/src/gurl.h"
+#include "net/base/load_flags.h"
 #include "net/http/http_response_headers.h"
 #include "third_party/libjingle/source/talk/xmllite/xmlparser.h"
 
 namespace {
 const char kAutofillQueryServerRequestUrl[] =
     "https://clients1.google.com/tbproxy/af/query?client=";
 const char kAutofillUploadServerRequestUrl[] =
     "https://clients1.google.com/tbproxy/af/upload?client=";
 const char kAutofillQueryServerNameStartInHeader[] = "GFE/";
 
@@ skipping 137 matching lines @@
 
   // Id is ignored for regular chrome, in unit test id's for fake fetcher
   // factory will be 0, 1, 2, ...
   content::URLFetcher* fetcher = content::URLFetcher::Create(
       fetcher_id_for_unittest_++, GURL(request_url), content::URLFetcher::POST,
       this);
   url_fetchers_[fetcher] = request_data;
   fetcher->SetAutomaticallyRetryOn5xx(false);
   fetcher->SetRequestContext(request_context);
   fetcher->SetUploadData("text/plain", form_xml);
+  fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);

[Ilya Sherman, 2012/02/29 22:45:27]

Do we want net::LOAD_DO_NOT_SEND_COOKIES as well?

[jochen (gone - plz use gerrit), 2012/02/29 22:52:26]

I don't know this code enough. I'd like to merge this into M17, and I'd rather
brea as little as possible

[Ilya Sherman, 2012/02/29 22:58:28]

I'm fairly sure not sending cookies should be safe for Autofill at least.  On
the other hand, if you're planning to merge this to M17, I agree that it might
be safer to disable sending cookies in a separate CL that doesn't get merged.

[GeorgeY, 2012/02/29 23:09:52]

Yes, Autofill does not use cookies at all, so it is safe to add
net::LOAD_DO_NOT_SEND_COOKIES, though I agree that it should be done in separate
cl.

   fetcher->Start();
   return true;
 }
 
 void AutofillDownloadManager::CacheQueryRequest(
     const std::vector<std::string>& forms_in_query,
     const std::string& query_data) {
   std::string signature = GetCombinedSignature(forms_in_query);
   for (QueryRequestCache::iterator it = cached_forms_.begin();
        it != cached_forms_.end(); ++it) {
@@ skipping 116 matching lines @@
         SetPositiveUploadRate(new_positive_upload_rate);
         SetNegativeUploadRate(new_negative_upload_rate);
       }
 
       observer_->OnUploadedPossibleFieldTypes();
     }
   }
   delete it->first;
   url_fetchers_.erase(it);
 }