Issue 9544001: ui: Let skia do the conversion work for us by using the integer version of set() function.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -110 lines)			Patch
M	ui/gfx/canvas_skia.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	ui/gfx/native_theme_android.cc	View	1 2 3 4 5 6 7	3 chunks	+8 lines, -15 lines	0 comments	Download
M	ui/gfx/native_theme_base.cc	View	1 2 3 4 5 6 7	2 chunks	+9 lines, -16 lines	0 comments	Download
M	ui/gfx/native_theme_chromeos.cc	View	1 2 3 4 5 6 7	6 chunks	+12 lines, -16 lines	0 comments	Download
M	ui/gfx/skia_util.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/bubble/bubble_border.cc	View	1 2 3 4	4 chunks	+6 lines, -13 lines	0 comments	Download
M	ui/views/controls/focusable_border.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -4 lines	0 comments	Download
M	ui/views/controls/menu/menu_image_util.cc	View		3 chunks	+6 lines, -10 lines	0 comments	Download
M	ui/views/controls/progress_bar.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/views/painter.cc	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl.cc	View	1 2 3 4 5	3 chunks	+4 lines, -8 lines	0 comments	Download
M	ui/views/view_unittest.cc	View		1 chunk	+3 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_android.cc File ui/gfx/native_theme_android.cc (right): http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_android.cc#newcode615 ui/gfx/native_theme_android.cc:615: SkRect dest_rect = { Nit: Could probably use ...

8 years, 9 months ago (2012-02-29 20:40:30 UTC) #2

tfarina

8 years, 9 months ago (2012-02-29 22:42:14 UTC) #3

http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_android.cc
File ui/gfx/native_theme_android.cc (right):

http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_android....
ui/gfx/native_theme_android.cc:615: SkRect dest_rect = {
On 2012/02/29 20:40:31, Peter Kasting wrote:
> Nit: Could probably use iset() here too

Done.

http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_base.cc
File ui/gfx/native_theme_base.cc (right):

http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_base.cc#...
ui/gfx/native_theme_base.cc:805: SkRect dest_rect = {
On 2012/02/29 20:40:31, Peter Kasting wrote:
> Nit: Can probably use iset() here too

Done.

http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_chromeos.cc
File ui/gfx/native_theme_chromeos.cc (right):

http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_chromeos...
ui/gfx/native_theme_chromeos.cc:693: SkRect sk_rect;
On 2012/02/29 20:40:31, Peter Kasting wrote:
> Nit: Shorter:
> 
>   canvas->drawRect(gfx::RectToSkRect(gfx::Rect(rect.size())), paint);

Done.

Expand Messages | Collapse Messages

Issue 9544001: ui: Let skia do the conversion work for us by using the integer version of set() function. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : simplify BubbleBackground::Paint #

Patch Set 4 : use SkPath directly #

Patch Set 5 : SkPath plus rm ui/gfx/path.h #

Patch Set 6 : SkPath on touch_selection_controller_impl.cc - looks like this file is not in any gyp? can be remov… #

Patch Set 7 : simplify FocusableBorder::Paint #

Patch Set 8 : peter review #

Messages