WebUI TaskManager: Remember column settings

chrome/browser/resources/task_manager/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @constructor */
 function TaskManager() { }
 
 cr.addSingletonGetter(TaskManager);
 
 var localStrings = new LocalStrings();
@@ skipping 73 matching lines @@
     measureTime.startInterval('Load.DOM');
 
     this.opt_ = opt;
 
     this.initialized_ = true;
 
     this.elementsCache_ = {};
     this.dialogDom_ = dialogDom;
     this.document_ = dialogDom.ownerDocument;
 
-    this.is_column_shown_ = [];
-    for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
-      this.is_column_shown_[i] = DEFAULT_COLUMNS[i][3];
-    }
-
     this.localized_column_ = [];
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column_label_id = DEFAULT_COLUMNS[i][1];
       var localized_label = localStrings.getString(column_label_id);
       // Falls back to raw column_label_id if localized string is not defined.
       if (localized_label == "")
         localized_label = column_label_id;
 
       this.localized_column_[i] = localized_label;
     }
@@ skipping 29 matching lines @@
               var aValue = aValues && aValues[0] || 0;
               var bvalue = bValues && bValues[0] || 0;
               return dm.defaultValuesCompareFunction(aValue, bvalue);
           };
       })();
       dm.setCompareFunction(columnId, compareFunc);
     }
 
     this.initTable_();
 
-    // enableTaskManager() must be called after enabling columns using
-    // setUpdateColumn() because it is necessary to tell the handler which
-    // columns to display before updating.
     commands.enableTaskManager();
 
     // Populate the static localized strings.
     i18nTemplate.process(this.document_, templateData);
 
     measureTime.recordInterval('Load.DOM');
     measureTime.recordInterval('Load.Total');
 
     loadDelayedIncludes(this);
   },
@@ skipping 51 matching lines @@
       }
     }
 
     this.isFinishedInitDelayed_ = true;
     this.table_.redraw();
   },
 
   initColumnModel_: function () {
     var table_columns = new Array();
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
-      if (!this.is_column_shown_[i])
+      var column = DEFAULT_COLUMNS[i];
+      var columnId = column[0];
+      if (!isColumnEnabled(columnId))
         continue;
 
-      var column = DEFAULT_COLUMNS[i];
-      var columnId = column[0];
       table_columns.push(new cr.ui.table.TableColumn(columnId,
                                                      this.localized_column_[i],
                                                      column[2]));
     }
 
     for (var i = 0; i < table_columns.length; i++) {
       table_columns[i].renderFunction = this.renderColumn_.bind(this);
     }
 
     this.columnModel_ = new cr.ui.table.TableColumnModel(table_columns);
@@ skipping 14 matching lines @@
       command.id = COMMAND_CONTEXTMENU_COLUMN_PREFIX + '-' + column[0];
       cr.ui.Command.decorate(command);
       this.column_menu_commands_[command.id] = command;
       this.commandsElement_.appendChild(command);
 
       // Creates menuitem element.
       var item = this.document_.createElement('menuitem');
       item.command = command;
       command.menuitem = item;
       item.textContent = this.localized_column_[i];
-      if (this.is_column_shown_[i])
+      if (isColumnEnabled(column[0]))
         item.setAttributeNode(this.document_.createAttribute("checked"));
       this.columnSelectContextMenu_.appendChild(item);
     }
 
     this.document_.body.appendChild(this.columnSelectContextMenu_);
     cr.ui.Menu.decorate(this.columnSelectContextMenu_);
 
     cr.ui.contextMenuHandler.setContextMenu(this.table_.header,
                                             this.columnSelectContextMenu_);
     cr.ui.contextMenuHandler.setContextMenu(this.table_.list,
@@ skipping 362 matching lines @@
 
     // Enables if the page can be inspected.
     if (target.data['canInspect'][index_in_group])
       inspect_menuitem.disabled = false;
 
     // Enables if the page can be activated.
     if (target.data['canActivate'][index_in_group])
       activate_menuitem.disabled = false;
   },
 
-  onColumnContextMenu_: function(id, command) {
+  onColumnContextMenu_: function(columnId, command) {
     var menuitem = command.menuitem;
-    var checked_item_count = 0;
-    var is_uncheck = 0;
+    var checkedItemCount = 0;
+    var checked = isColumnEnabled(columnId);
 
     // Leaves a item visible when user tries making invisible but it is the
     // last one.
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column = DEFAULT_COLUMNS[i];
-      if (column[0] == id && this.is_column_shown_[i]) {
-        is_uncheck = 1;
-      }
-      if (this.is_column_shown_[i])
-        checked_item_count++;
+      if (isColumnEnabled(column[0]))
+        checkedItemCount++;
     }
-    if (checked_item_count == 1 && is_uncheck) {
+    if (checkedItemCount == 1 && checked) {

[James Hawkins, 2012/03/01 20:03:09]

nit: No braces for single-line blocks.

       return;
     }
 
     // Toggles the visibility of the column.
-    for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
-      var column = DEFAULT_COLUMNS[i];
-      if (column[0] == id) {
-        this.is_column_shown_[i] = !this.is_column_shown_[i];
-        var checked = this.is_column_shown_[i];
-        menuitem.checked = checked;
-        this.initColumnModel_()
-        this.table_.columnModel = this.columnModel_;
-        this.table_.redraw();
+    var newChecked = !checked;
+    menuitem.checked = newChecked;
 
-        commands.setUpdateColumn(column[0], checked);
-        return;
-      }
-    }
+    var enabledColumns = getEnabledColumns();
+    enabledColumns[columnId] = newChecked;
+    setEnabledColumns(enabledColumns);
+    commands.setUpdateColumn(columnId, newChecked);
+
+    this.initColumnModel_()
+    this.table_.columnModel = this.columnModel_;
+    this.table_.redraw();
   },
 };
 
 // |taskmanager| has been declared in preload.js.
 taskmanager = TaskManager.getInstance();
 
 function init() {
   var params = parseQueryParams(window.location);
   var opt = {};
   opt['isShowTitle'] = params.showtitle;
   opt['isBackgroundMode'] = params.background;
   opt['isShowCloseButton'] = params.showclose;
   taskmanager.initialize(document.body, opt);
 }
 
 document.addEventListener('DOMContentLoaded', init);
 document.addEventListener('Close', taskmanager.onClose.bind(taskmanager));