Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 9537015: Adds "Certificate Information" label for page_info_model. (Closed)

Created:
8 years, 9 months ago by bulach
Modified:
8 years, 9 months ago
Reviewers:
Jay Civelli, jcampan
CC:
chromium-reviews
Visibility:
Public.

Description

Adds "Certificate Information" label for page_info_model. On android, we have a slightly different design for the page info requiring this extra label. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/page_info_model.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/page_info_model.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
8 years, 9 months ago (2012-02-29 16:33:37 UTC) #1
Jay Civelli
lgtm
8 years, 9 months ago (2012-02-29 16:47:51 UTC) #2
bulach
thanks jay! I'll put through the CQ now... jcampan, happy to follow up if you ...
8 years, 9 months ago (2012-03-02 09:34:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/9537015/1
8 years, 9 months ago (2012-03-02 09:34:57 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 15:55:41 UTC) #5
Change committed as 124646

Powered by Google App Engine
This is Rietveld 408576698