Move |requires_authorization| flag for plug-ins out of webkit/

Move |requires_authorization| flag and |update_url| for plug-ins out of webkit::npapi::PluginGroup.

It's now in PluginInstaller.

BUG=none
TEST=nope

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128949

[Bernhard Bauer, 2012-03-02 09:23:14]

Please review.

[jam, 2012-03-02 15:56:19]

On 2012/03/02 09:23:14, Bernhard Bauer wrote:
> Please review.

this requires_authorization stuff seems like a layering violation in the webkit
layer, since that seems like a chrome UI concept

[Bernhard Bauer, 2012-03-02 16:37:17]

On 2012/03/02 15:56:19, John Abd-El-Malek wrote:
> On 2012/03/02 09:23:14, Bernhard Bauer wrote:
> > Please review.
> 
> this requires_authorization stuff seems like a layering violation in the
webkit
> layer, since that seems like a chrome UI concept

Very true, I think all of PluginGroup should live just in chrome/ (and maybe
just be called Plugin?). That's a bigger refactoring though, as right now
PluginList has its WebPluginInfos inside of PluginGroups, and we need to
untangle all of that.

[jam, 2012-03-02 19:14:02]

On 2012/03/02 16:37:17, Bernhard Bauer wrote:
> On 2012/03/02 15:56:19, John Abd-El-Malek wrote:
> > On 2012/03/02 09:23:14, Bernhard Bauer wrote:
> > > Please review.
> > 
> > this requires_authorization stuff seems like a layering violation in the
> webkit
> > layer, since that seems like a chrome UI concept
> 
> Very true, I think all of PluginGroup should live just in chrome/ (and maybe
> just be called Plugin?). That's a bigger refactoring though, as right now
> PluginList has its WebPluginInfos inside of PluginGroups, and we need to
> untangle all of that.

can we just the authorization stuff for now to some singleton in chrome?

[Bernhard Bauer, 2012-03-09 17:09:05]

On 2012/03/02 19:14:02, John Abd-El-Malek wrote:
> can we just the authorization stuff for now to some singleton in chrome?

OK, I moved it (and update_url) into PluginInstaller. PTAL?

[jam, 2012-03-09 19:10:08]

lgtm

http://codereview.chromium.org/9536013/diff/17019/chrome/browser/ui/webui/plu...
File chrome/browser/ui/webui/plugins_ui.cc (right):

http://codereview.chromium.org/9536013/diff/17019/chrome/browser/ui/webui/plu...
chrome/browser/ui/webui/plugins_ui.cc:156: // XXX
?

[Bernhard Bauer, 2012-03-09 20:28:12]

James, can you take a look at webui/?

Thanks!

http://codereview.chromium.org/9536013/diff/17019/chrome/browser/ui/webui/plu...
File chrome/browser/ui/webui/plugins_ui.cc (right):

http://codereview.chromium.org/9536013/diff/17019/chrome/browser/ui/webui/plu...
chrome/browser/ui/webui/plugins_ui.cc:156: // XXX
On 2012/03/09 19:10:08, John Abd-El-Malek wrote:
> ?

Forgot a comment :)

[James Hawkins, 2012-03-09 21:59:12]

LGTM

[commit-bot: I haz the power, 2012-03-09 23:04:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9536013/26001

[commit-bot: I haz the power, 2012-03-09 23:32:08]

Try job failure for 9536013-26001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-03-19 12:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9536013/32001

[commit-bot: I haz the power, 2012-03-19 13:09:40]

Try job failure for 9536013-32001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-03-19 14:24:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9536013/35003

[commit-bot: I haz the power, 2012-03-19 14:24:39]

Can't apply patch for file webkit/plugins/npapi/plugin_list.cc.
While running patch -p1 --forward --force;
patching file webkit/plugins/npapi/plugin_list.cc
Hunk #1 FAILED at 53.
1 out of 4 hunks FAILED -- saving rejects to file
webkit/plugins/npapi/plugin_list.cc.rej

[commit-bot: I haz the power, 2012-03-19 15:04:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9536013/39023

[commit-bot: I haz the power, 2012-03-19 15:26:31]

Try job failure for 9536013-39023 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Bernhard Bauer, 2012-03-20 18:09:33]

John, there have been some changes since your LGTM. Do you want to take another
look? (The interesting changes are between patch set 11 and 13)

[commit-bot: I haz the power, 2012-03-22 10:52:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9536013/44003

[commit-bot: I haz the power, 2012-03-22 10:52:47]

Presubmit check for 9536013-44003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template gets
instantiated in a single compilation unit.
  chrome/browser/plugin_finder.h

Presubmit checks took 2.1s to calculate.

[commit-bot: I haz the power, 2012-03-26 15:13:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/9536013/62001

[commit-bot: I haz the power, 2012-03-26 18:03:28]

Change committed as 128949