Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 9535008: WebUI TaskManager: Make the button "End process" grayed on selecting the browser process. (Closed)

Created:
8 years, 9 months ago by yoshiki
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins, kgr
CC:
chromium-reviews, yoshiki+watch_chromium.org
Visibility:
Public.

Description

WebUI TaskManager: Make the button "End process" grayed on selecting the browser process. This regression is due to lack of 'type' information of task in task list data from the handler to javascript. This has been caused by http://crrev.com/119052. BUG=115380 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/task_manager_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yoshiki
Could you take a look?
8 years, 9 months ago (2012-03-01 09:27:26 UTC) #1
James Hawkins
LGTM
8 years, 9 months ago (2012-03-01 20:03:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/9535008/1
8 years, 9 months ago (2012-03-02 04:48:27 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 16:12:59 UTC) #4
Change committed as 124663

Powered by Google App Engine
This is Rietveld 408576698