Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 9535003: Fix WeakPtr's thread restriction violation in chromeos::CertLibrary (Closed)

Created:
8 years, 9 months ago by hashimoto
Modified:
8 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix WeakPtr's thread restriction violation in chromeos::CertLibrary BUG=116202 TEST=Login success Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/chromeos/cros/cert_library.cc View 5 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
This patch is to replace mistakenly introduced (in http://src.chromium.org/viewvc/chrome?view=rev&revision=123956) WeakPtr with base::Unretained.
8 years, 9 months ago (2012-02-29 07:37:05 UTC) #1
stevenjb
lgtm
8 years, 9 months ago (2012-02-29 18:26:43 UTC) #2
keybuk
verifying that this fixes it for me
8 years, 9 months ago (2012-02-29 18:28:10 UTC) #3
keybuk
lgtm
8 years, 9 months ago (2012-02-29 18:45:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9535003/1
8 years, 9 months ago (2012-03-01 02:48:00 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 06:28:46 UTC) #6
Change committed as 124374

Powered by Google App Engine
This is Rietveld 408576698