Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 9535002: GTK: Update ImageLoadingTracker::Observer subclasses (Closed)

Created:
8 years, 9 months ago by sail
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, Mihai Parparita -not on Chrome, Finnur
Visibility:
Public.

Description

GTK: Update ImageLoadingTracker::Observer subclasses BUG=112651 TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -39 lines) Patch
M chrome/browser/shell_integration_linux.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 2 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sail
This is the GTK portion of the multiple icon size CL (http://codereview.chromium.org/9428025/)
8 years, 9 months ago (2012-02-29 04:49:56 UTC) #1
Mihai Parparita -not on Chrome
LGTM, but you'll need one of the chrome/browser/ui/gtk OWNERS too.
8 years, 9 months ago (2012-02-29 05:08:10 UTC) #2
Elliot Glaysher
8 years, 9 months ago (2012-02-29 20:03:47 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698