DCHECK sets a variable, instead of comparing

DCHECK sets a variable, instead of comparing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124327

[michaeln, 2012-02-29 20:35:27]

lgtm (thank you!)

http://codereview.chromium.org/9534003/diff/1/webkit/appcache/web_application...
File webkit/appcache/web_application_cache_host_impl.cc (right):

http://codereview.chromium.org/9534003/diff/1/webkit/appcache/web_application...
webkit/appcache/web_application_cache_host_impl.cc:229:
DCHECK(is_new_master_entry_ == NO);
yikes!

[michaeln, 2012-02-29 20:36:25]

http://codereview.chromium.org/9534003/diff/1/webkit/appcache/web_application...
File webkit/appcache/web_application_cache_host_impl.cc (right):

http://codereview.chromium.org/9534003/diff/1/webkit/appcache/web_application...
webkit/appcache/web_application_cache_host_impl.cc:229:
DCHECK(is_new_master_entry_ == NO);
actually, would be good to use DCHECK_EQ(NO, is_new) here.

[jennb, 2012-02-29 20:37:57]

LGTM

What michaeln said - yikes, indeed!

On 2012/02/29 20:36:25, michaeln wrote:
>
http://codereview.chromium.org/9534003/diff/1/webkit/appcache/web_application...
> File webkit/appcache/web_application_cache_host_impl.cc (right):
> 
>
http://codereview.chromium.org/9534003/diff/1/webkit/appcache/web_application...
> webkit/appcache/web_application_cache_host_impl.cc:229:
> DCHECK(is_new_master_entry_ == NO);
> actually, would be good to use DCHECK_EQ(NO, is_new) here.

[Myles C. Maxfield, 2012-02-29 22:11:40]

https://chromiumcodereview.appspot.com/9534003/diff/1/webkit/appcache/web_app...
File webkit/appcache/web_application_cache_host_impl.cc (right):

https://chromiumcodereview.appspot.com/9534003/diff/1/webkit/appcache/web_app...
webkit/appcache/web_application_cache_host_impl.cc:229:
DCHECK(is_new_master_entry_ == NO);
On 2012/02/29 20:36:25, michaeln wrote:
> actually, would be good to use DCHECK_EQ(NO, is_new) here.

Done.

[commit-bot: I haz the power, 2012-02-29 22:13:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmaxfield@google.com/9534003/5001

[commit-bot: I haz the power, 2012-03-01 01:52:55]

Change committed as 124327