Try adding memory corruption check in ThreadCache::Deallocate.

Try adding memory corruption check in ThreadCache::Deallocate.

It fails in gtest by memory corruption error like:
* http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/430/steps/base_unittests/logs/stdio
* http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/430/steps/unit_tests/logs/stdio

This check is imported from the latest tcmalloc library: full update at http://codereview.chromium.org/9311003/


BUG=116201
TEST=run tests using gtest.  (e.g. unit_tests)

[jar (doing other things), 2012-03-01 19:36:37]

lgtm

http://codereview.chromium.org/9528002/diff/2001/third_party/tcmalloc/chromiu...
File third_party/tcmalloc/chromium/src/free_list.cc (right):

http://codereview.chromium.org/9528002/diff/2001/third_party/tcmalloc/chromiu...
third_party/tcmalloc/chromium/src/free_list.cc:153: // Maybe required here? :
FL_SetNext(result, NULL);
An item pulled from the list is not guaranteed to have any specific contents, so
there is no real value in "cleaning up" the item that we popped.

[Dai Mikurube (NOT FULLTIME), 2012-03-01 21:04:11]

Thanks, Jim.

I'll merge this change (ASSERT) in the TCMalloc update change:
http://codereview.chromium.org/9311003/.

http://codereview.chromium.org/9528002/diff/2001/third_party/tcmalloc/chromiu...
File third_party/tcmalloc/chromium/src/free_list.cc (right):

http://codereview.chromium.org/9528002/diff/2001/third_party/tcmalloc/chromiu...
third_party/tcmalloc/chromium/src/free_list.cc:153: // Maybe required here? :
FL_SetNext(result, NULL);
On 2012/03/01 19:36:38, jar wrote:
> An item pulled from the list is not guaranteed to have any specific contents,
so
> there is no real value in "cleaning up" the item that we popped.

Make sense.  I don't change here.

[Dai Mikurube (NOT FULLTIME), 2012-03-06 00:28:38]

Closing this change.