Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 9522016: Settings->Advanced->Content settings are now applied correctly in Guest Mode (Closed)

Created:
8 years, 9 months ago by Denis Kuznetsov (DE-MUC)
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Settings->Advanced->Content settings are now applied correctly in Guest Mode BUG=chromium-os:13205 TEST=Tested manually. Content settings work correctly in Guest mode, but are not stored to Default settings (as expected) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124391

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit fix #

Patch Set 3 : Merge with trunk #

Patch Set 4 : Try upload again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/webui/options2/content_settings_handler2.cc View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Denis Kuznetsov (DE-MUC)
8 years, 9 months ago (2012-02-29 14:32:39 UTC) #1
James Hawkins
lgtm https://chromiumcodereview.appspot.com/9522016/diff/1/chrome/browser/ui/webui/options2/content_settings_handler2.cc File chrome/browser/ui/webui/options2/content_settings_handler2.cc (right): https://chromiumcodereview.appspot.com/9522016/diff/1/chrome/browser/ui/webui/options2/content_settings_handler2.cc#newcode719 chrome/browser/ui/webui/options2/content_settings_handler2.cc:719: if (chromeos::UserManager::Get()->IsLoggedInAsGuest()) { Optional nit: no braces for ...
8 years, 9 months ago (2012-02-29 15:15:09 UTC) #2
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/9522016/diff/1/chrome/browser/ui/webui/options2/content_settings_handler2.cc File chrome/browser/ui/webui/options2/content_settings_handler2.cc (right): https://chromiumcodereview.appspot.com/9522016/diff/1/chrome/browser/ui/webui/options2/content_settings_handler2.cc#newcode719 chrome/browser/ui/webui/options2/content_settings_handler2.cc:719: if (chromeos::UserManager::Get()->IsLoggedInAsGuest()) { On 2012/02/29 15:15:09, James Hawkins wrote: ...
8 years, 9 months ago (2012-02-29 15:55:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/9522016/4001
8 years, 9 months ago (2012-02-29 15:56:18 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/webui/options2/content_settings_handler2.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/options2/content_settings_handler2.cc ...
8 years, 9 months ago (2012-02-29 15:56:22 UTC) #5
Denis Kuznetsov (DE-MUC)
Please take a brief look again -- had to merge with trunk.
8 years, 9 months ago (2012-02-29 16:06:28 UTC) #6
James Hawkins
lgtm
8 years, 9 months ago (2012-02-29 20:25:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/9522016/5002
8 years, 9 months ago (2012-03-01 06:36:54 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 09:42:22 UTC) #9
Change committed as 124391

Powered by Google App Engine
This is Rietveld 408576698