Cleanup some classnames to match style.

Cleanup some classnames to match style.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124392

[eroman, 2012-02-28 21:47:33]

To understand this change please start with "main.css".

[mmenke, 2012-02-28 22:15:01]

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
File chrome/browser/resources/net_internals/main.css (right):

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:1: /*
Should we be putting a second asterisk on these?

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:43: * DIV). It gives them a
consistent margin, and makes them scrollable. */
nit:  Should make this consistent with the other comments:

/*
 * Blah
 */

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:44: .content-box {
Much better.

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:58: .styled-table td {
The unit tests use the name of this class to make locating tables a little
easier, so you'll need to update NetInternalsTest.getStyledTableDescendent as
well.

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
File chrome/browser/resources/net_internals/service_providers_view.html (right):

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/service_providers_view.html:4: <table
class="styled-table">
Hmm...sometime we use quotes on single class names, sometimes we don't.  Should
we try and be more consistent?

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
File chrome/browser/resources/net_internals/sockets_view.html (right):

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/sockets_view.html:9: <span
class=warning-text >May break pages with active connections</span>
nit:  While you're here...Is that space needed?

[eroman, 2012-02-28 22:28:31]

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
File chrome/browser/resources/net_internals/main.css (right):

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:1: /*
On 2012/02/28 22:15:02, Matt Menke wrote:
> Should we be putting a second asterisk on these?

We have some inconsistencies. I'll do another pass and try to match them all.
For this CL will leave as-is (I just need to add the spaces so liscence
pre-submit doesn't barf).

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:43: * DIV). It gives them a
consistent margin, and makes them scrollable. */
On 2012/02/28 22:15:02, Matt Menke wrote:
> nit:  Should make this consistent with the other comments:
> 
> /*
>  * Blah
>  */

Done.

However we use both styles in this file.

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/main.css:58: .styled-table td {
On 2012/02/28 22:15:02, Matt Menke wrote:
> The unit tests use the name of this class to make locating tables a little
> easier, so you'll need to update NetInternalsTest.getStyledTableDescendent as
> well.

Done.

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
File chrome/browser/resources/net_internals/service_providers_view.html (right):

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/service_providers_view.html:4: <table
class="styled-table">
On 2012/02/28 22:15:02, Matt Menke wrote:
> Hmm...sometime we use quotes on single class names, sometimes we don't. 
Should
> we try and be more consistent?

indeed.

I'll leave that to a follow-up.

My inclination is towards fewer characters (i.e. use no quotes when possible)

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
File chrome/browser/resources/net_internals/sockets_view.html (right):

https://chromiumcodereview.appspot.com/9521006/diff/3002/chrome/browser/resou...
chrome/browser/resources/net_internals/sockets_view.html:9: <span
class=warning-text >May break pages with active connections</span>
On 2012/02/28 22:15:02, Matt Menke wrote:
> nit:  While you're here...Is that space needed?

Done.

[mmenke, 2012-02-29 16:43:32]

LGTM.

[commit-bot: I haz the power, 2012-03-01 07:34:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/9521006/11001

[commit-bot: I haz the power, 2012-03-01 09:46:11]

Change committed as 124392