Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 9516010: Added PrinterDriverInfo and PrintBackend::GetPrinterDriverInfo for windows. (Closed)

Created:
8 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 9 months ago
Reviewers:
Albert Bodenhamer, gene
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Added PrinterDriverInfo and PrintBackend::GetPrinterDriverInfo for windows. BUG=108194 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125020

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Total comments: 2

Patch Set 5 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M printing/backend/print_backend.h View 2 chunks +15 lines, -0 lines 0 comments Download
M printing/backend/print_backend.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M printing/backend/print_backend_chromeos.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M printing/backend/print_backend_cups.cc View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 2 3 chunks +45 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 9 months ago (2012-03-01 19:27:25 UTC) #1
Albert Bodenhamer
http://codereview.chromium.org/9516010/diff/15002/base/win/scoped_handle.h File base/win/scoped_handle.h (right): http://codereview.chromium.org/9516010/diff/15002/base/win/scoped_handle.h#newcode1 base/win/scoped_handle.h:1: // Copyright (c) 2010 The Chromium Authors. All rights ...
8 years, 9 months ago (2012-03-02 21:14:03 UTC) #2
Vitaly Buka (NO REVIEWS)
Sorry, but I already pushed unrelated parts of CL into CQ. I will remove changes ...
8 years, 9 months ago (2012-03-02 22:45:25 UTC) #3
Vitaly Buka (NO REVIEWS)
Please review now.
8 years, 9 months ago (2012-03-03 00:30:54 UTC) #4
Albert Bodenhamer
lgtm http://codereview.chromium.org/9516010/diff/12009/printing/backend/print_backend_cups.cc File printing/backend/print_backend_cups.cc (right): http://codereview.chromium.org/9516010/diff/12009/printing/backend/print_backend_cups.cc#newcode233 printing/backend/print_backend_cups.cc:233: // TODO(vitalybuka): implement this. Reference the bug number ...
8 years, 9 months ago (2012-03-05 17:57:53 UTC) #5
Vitaly Buka (NO REVIEWS)
http://codereview.chromium.org/9516010/diff/12009/printing/backend/print_backend_cups.cc File printing/backend/print_backend_cups.cc (right): http://codereview.chromium.org/9516010/diff/12009/printing/backend/print_backend_cups.cc#newcode233 printing/backend/print_backend_cups.cc:233: // TODO(vitalybuka): implement this. On 2012/03/05 17:57:53, Albert Bodenhamer ...
8 years, 9 months ago (2012-03-05 19:24:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9516010/22001
8 years, 9 months ago (2012-03-05 19:25:58 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-05 23:17:28 UTC) #8
Change committed as 125020

Powered by Google App Engine
This is Rietveld 408576698