SPDY - disable spdy/2.1 (flow control) by default

net/http/http_stream_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_H_
 
 #include <list>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/string16.h"
 #include "net/base/completion_callback.h"
 #include "net/base/load_states.h"
 #include "net/base/net_export.h"
+#include "net/http/http_server_properties.h"

[Ryan Hamilton, 2012/03/02 16:46:53]

Is this import needed?

[ramant (doing other things), 2012/03/02 18:40:41]

It is needed because of NUM_ALTERNATE_PROTOCOLS.

 #include "net/socket/ssl_client_socket.h"
 
 class GURL;
 
 namespace base {
 class Value;
 }
 
 namespace net {
 
@@ skipping 194 matching lines @@
   static void set_force_spdy_always(bool value) {
     force_spdy_always_ = value;
   }
   static bool force_spdy_always() { return force_spdy_always_; }
 
   // Add a URL to exclude from forced SPDY.
   static void add_forced_spdy_exclusion(const std::string& value);
   // Check if a HostPortPair is excluded from using spdy.
   static bool HasSpdyExclusion(const HostPortPair& endpoint);
 
   // Sets the next protocol negotiation value used during the SSL handshake.

[Ryan Hamilton, 2012/03/02 16:46:53]

Please update comment. I believe this vector is use to negotiate a protocol via
SSL NPN, as well as via HTTP Alternate-Protocol.

[ramant (doing other things), 2012/03/02 18:40:41]

Done.

-  static void set_next_protos(const std::vector<std::string>& value) {
-    if (!next_protos_)
-      next_protos_ = new std::vector<std::string>;
-    *next_protos_ = value;
-  }
+  static void SetNextProtos(const std::vector<std::string>& value);
   static bool has_next_protos() { return next_protos_ != NULL; }
   static const std::vector<std::string>& next_protos() {
     return *next_protos_;
   }
 
   // Sets the HttpStreamFactoryImpl into a mode where it can ignore certificate
   // errors.  This is for testing.
   static void set_ignore_certificate_errors(bool value) {
     ignore_certificate_errors_ = value;
   }
@@ skipping 19 matching lines @@
   static uint16 testing_fixed_https_port() { return testing_fixed_https_port_; }
 
  protected:
   HttpStreamFactory();
 
  private:
   static const HostMappingRules& host_mapping_rules();
 
   static const HostMappingRules* host_mapping_rules_;
   static std::vector<std::string>* next_protos_;
+  static bool supported_protocols_[NUM_ALTERNATE_PROTOCOLS];

[Ryan Hamilton, 2012/03/02 16:46:53]

nit: I think I would call this enabled_protocols_, because Chrome "supports" all
of them, but some might be disabled via command line flags.

[ramant (doing other things), 2012/03/02 18:40:41]

Done.

   static bool spdy_enabled_;
   static bool use_alternate_protocols_;
   static bool force_spdy_over_ssl_;
   static bool force_spdy_always_;
   static std::list<HostPortPair>* forced_spdy_exclusions_;
   static bool ignore_certificate_errors_;
   static bool http_pipelining_enabled_;
   static uint16 testing_fixed_http_port_;
   static uint16 testing_fixed_https_port_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpStreamFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_H_