Move the build config logic for our memory tools into common.gypi.

Move the build config logic for our memory tools into common.gypi.

This change allows us to tweak these options without restarting the
build masters and submit try jobs that tweak them.

It also simplifies usage of these tools, because instead of copying and
pasting a large block of gyp variables from
tools/build/scripts/masters/factor/chromium_factory.py into GYP_DEFINES
or .gyp/include.gyp, developers can simply set build_for_tool=mytool.

My plan is to change the chromium.fyi master to use build_for_tool=*
first, and revert if those bots break.  If they stay green, I'll send a
change to update chromium.memory.fyi and completely remove
ChromiumFactory.MEMORY_TOOLS_GYP_DEFINES.

I intend to remove all the otherwise unused (win_)(release|debug)_*
options that we exposed later.  This change is supposed to be the
simplest thing that works.

R=maruel@chromium.org,timurrrr@chromium.org
BUG=109780
TEST=built with build_for_tool=drmemory locally


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124323

[Marc-Antoine Ruel (Google), 2012-02-29 00:03:41]

lgtm

https://chromiumcodereview.appspot.com/9516005/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9516005/diff/1/build/common.gypi#newco...
build/common.gypi:960: '-g -fno-inline -fno-omit-frame-pointer -fno-builtin
-fno-optimize-sibling-calls',
style nit: you can split it up in 80 cols with python string concatenation.

[Timur Iskhodzhanov, 2012-02-29 09:14:18]

LGTM with a couple of suggestions

https://chromiumcodereview.appspot.com/9516005/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9516005/diff/1/build/common.gypi#newco...
build/common.gypi:964: # MSVS flags
# MSVS flags for TSan/Win

https://chromiumcodereview.appspot.com/9516005/diff/1/build/common.gypi#newco...
build/common.gypi:979: # TODO(timurrrr): Investigate http://crbug.com/108155 . 
It would be nice
maybe you should move the comment a few lines down to correspond to the
commented-out lines

[Reid Kleckner, 2012-02-29 20:20:16]

mostly comment changes, going to CQ

http://codereview.chromium.org/9516005/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9516005/diff/1/build/common.gypi#newcode960
build/common.gypi:960: '-g -fno-inline -fno-omit-frame-pointer -fno-builtin
-fno-optimize-sibling-calls',
On 2012/02/29 00:03:41, Marc-Antoine Ruel (Google) wrote:
> style nit: you can split it up in 80 cols with python string concatenation.

GYP is parsed with Python syntax rules and not JSON rules?

http://codereview.chromium.org/9516005/diff/1/build/common.gypi#newcode964
build/common.gypi:964: # MSVS flags
On 2012/02/29 09:14:18, Timur Iskhodzhanov wrote:
> # MSVS flags for TSan/Win

Done.

http://codereview.chromium.org/9516005/diff/1/build/common.gypi#newcode979
build/common.gypi:979: # TODO(timurrrr): Investigate http://crbug.com/108155 . 
It would be nice
On 2012/02/29 09:14:18, Timur Iskhodzhanov wrote:
> maybe you should move the comment a few lines down to correspond to the
> commented-out lines

I think of the comment as referring to the separation of these two configs
instead of the commented the lines.  If we fix that bug (I'm investigating a
shadow callstack), then we should combine these blocks.  Otherwise we can't be
as confident that the two configs are the same.

[commit-bot: I haz the power, 2012-02-29 20:20:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/9516005/6001

[commit-bot: I haz the power, 2012-02-29 20:25:41]

Try job failure for 9516005-6001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-02-29 20:38:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/9516005/14001

[commit-bot: I haz the power, 2012-02-29 22:09:40]

Try job failure for 9516005-14001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-02-29 22:16:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/9516005/14001

[commit-bot: I haz the power, 2012-03-01 01:29:48]

Change committed as 124323