Issue 9515005: [chromedriver] Add command for uploading a file to a remote ChromeDriver server,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9515005: [chromedriver] Add command for uploading a file to a remote ChromeDriver server, (Closed)

Created:
8 years, 9 months ago by kkania

Modified:
8 years, 9 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, kkania, bustamante1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Add command for uploading a file to a remote ChromeDriver server, which can be used when performing a file upload using sendKeys. Unfortunately, past and current versions of some WebDriver clients, including java, only upload a zip entry and not an actual zip. This can't be parsed by chromium's zip utilities or minizip. The WebDriver clients should be changed to send an actual zip file. In the meantime, we append a central directory on to the zip entry and then unzip it. BUG=chromedriver:18 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125004

Patch Set 1 : . #

Patch Set 2 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+532 lines, -53 lines)			Patch
M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/webdriver/commands/file_upload_command.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/test/webdriver/commands/file_upload_command.cc	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_capabilities_parser.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_capabilities_parser.cc	View	1	4 chunks	+8 lines, -40 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_server.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_session.h	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_session.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_util.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_util.cc	View		2 chunks	+359 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_util_unittest.cc	View		2 chunks	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/9515005/11001

8 years, 9 months ago (2012-03-05 19:51:44 UTC) #3

Change committed as 125004

Expand Messages | Collapse Messages