Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: ash/wm/base_layout_manager.cc

Issue 9515003: Fix the full screen switching browser window dipping below launcher bar issue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make SetWorkSpaceBounds private. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/base_layout_manager.h ('k') | ash/wm/base_layout_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/base_layout_manager.cc
diff --git a/ash/wm/base_layout_manager.cc b/ash/wm/base_layout_manager.cc
index e8a5014feaa51e42e9cf13a3552d83d27d20f4d1..f43db88ec61b8c5119dea7e27879374440719538 100644
--- a/ash/wm/base_layout_manager.cc
+++ b/ash/wm/base_layout_manager.cc
@@ -67,21 +67,11 @@ void BaseLayoutManager::SetChildBounds(aura::Window* child,
// BaseLayoutManager, RootWindowObserver overrides:
void BaseLayoutManager::OnRootWindowResized(const gfx::Size& new_size) {
- // If a user plugs an external monitor into a laptop running Aura the
- // monitor size will change. Maximized windows need to resize to match.
- // We also do this when developers running Aura on a desktop manually resize
- // the host window.
- for (WindowSet::const_iterator it = windows_.begin();
- it != windows_.end();
- ++it) {
- aura::Window* window = *it;
- // The work area may be smaller than the full screen.
- gfx::Rect monitor_rect = wm::IsWindowFullscreen(window) ?
- gfx::Screen::GetMonitorAreaNearestWindow(window) :
- gfx::Screen::GetMonitorWorkAreaNearestWindow(window);
- // Put as much of the window as possible within the monitor area.
- window->SetBounds(window->bounds().AdjustToFit(monitor_rect));
- }
+ AdjustWindowSizesForScreenChange();
+}
+
+void BaseLayoutManager::OnScreenWorkAreaInsetsChanged() {
+ AdjustWindowSizesForScreenChange();
}
/////////////////////////////////////////////////////////////////////////////
@@ -124,5 +114,24 @@ void BaseLayoutManager::UpdateBoundsFromShowState(aura::Window* window) {
}
}
+void BaseLayoutManager::AdjustWindowSizesForScreenChange() {
+ // If a user plugs an external monitor into a laptop running Aura the
+ // monitor size will change. Maximized windows need to resize to match.
+ // We also do this when developers running Aura on a desktop manually resize
+ // the host window.
+ // We also need to do this when the work area insets changes.
+ for (WindowSet::const_iterator it = windows_.begin();
+ it != windows_.end();
+ ++it) {
+ aura::Window* window = *it;
+ // The work area may be smaller than the full screen.
+ gfx::Rect monitor_rect = wm::IsWindowFullscreen(window) ?
+ gfx::Screen::GetMonitorAreaNearestWindow(window) :
+ gfx::Screen::GetMonitorWorkAreaNearestWindow(window);
+ // Put as much of the window as possible within the monitor area.
+ window->SetBounds(window->bounds().AdjustToFit(monitor_rect));
+ }
+}
+
} // namespace internal
} // namespace ash
« no previous file with comments | « ash/wm/base_layout_manager.h ('k') | ash/wm/base_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698