Fixing a problem, where a hung renderer process is not killed when navigating away

content/browser/renderer_host/mock_render_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/mock_render_process_host.h"
 
 #include "base/lazy_instance.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "content/browser/child_process_security_policy_impl.h"
@@ skipping 195 matching lines @@
   return listeners_iterator(&listeners);
 }
 
 bool MockRenderProcessHost::OnMessageReceived(const IPC::Message& msg) {
   return false;
 }
 
 void MockRenderProcessHost::OnChannelConnected(int32 peer_pid) {
 }
 
+bool MockRenderProcessHost::AllowTerminateOnUnresponsive() const {
+  if (listeners_.size() > 1)
+    return false;

[Charlie Reis, 2012/03/01 21:08:17]

Is this necessary for tests?  Usually the Mock version just hardcodes a
reasonable answer, like true.

[nasko, 2012/03/01 22:50:15]

Is there a reason to have a hardcoded value, especially with such a simple
function body?

[Charlie Reis, 2012/03/02 00:16:43]

In general, it might get out of date if we change the other one.  It might also
not do what you think, depending on how listeners_ is updated in the Mock.

[nasko, 2012/03/02 18:40:36]

If the function is now renamed to IsSharedByMultipleViews, does it make sense to
hard code the value, especially when the mock host does proper accounting for
listeners?

[Charlie Reis, 2012/03/02 19:17:02]

No, we can leave it as is.

+
+  return true;
+}
+
 MockRenderProcessHostFactory::MockRenderProcessHostFactory() {}
 
 MockRenderProcessHostFactory::~MockRenderProcessHostFactory() {
   // Detach this object from MockRenderProcesses to prevent STLDeleteElements()
   // from calling MockRenderProcessHostFactory::Remove().
   for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
        it != processes_.end(); ++it) {
     (*it)->SetFactory(NULL);
   }
 }
@@ skipping 11 matching lines @@
 
 void MockRenderProcessHostFactory::Remove(MockRenderProcessHost* host) const {
   for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
        it != processes_.end(); ++it) {
     if (*it == host) {
       processes_.weak_erase(it);
       break;
     }
   }
 }