Force URL in settings page to be left-to-right.

chrome/browser/ui/webui/options2/browser_options_handler2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options2/browser_options_handler2.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
+#include "base/i18n/rtl.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/value_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/auto_launch_trial.h"
 #include "chrome/browser/autocomplete/autocomplete.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
@@ skipping 515 matching lines @@
 
 void BrowserOptionsHandler::UpdateHomePageLabel() const {
   Profile* profile = Profile::FromWebUI(web_ui());
   PrefService* prefs = profile->GetPrefs();
   scoped_ptr<Value> label;
   string16 str;
 
   if (prefs->GetBoolean(prefs::kHomePageIsNewTabPage)) {
     str = l10n_util::GetStringUTF16(IDS_OPTIONS_SHOW_HOME_BUTTON_FOR_NTP);
   } else {
+    string16 home_page = UTF8ToUTF16(prefs->GetString(prefs::kHomePage));
+    if (base::i18n::IsRTL())
+      base::i18n::WrapStringWithLTRFormatting(&home_page);
     str = l10n_util::GetStringFUTF16(
-        IDS_OPTIONS_SHOW_HOME_BUTTON_FOR_URL,
-        UTF8ToUTF16(prefs->GetString(prefs::kHomePage)));
+        IDS_OPTIONS_SHOW_HOME_BUTTON_FOR_URL, home_page);

[Evan Stade, 2012/02/28 22:22:43]

does it not work to just set dir=ltr on the DOM node?

[xji, 2012/02/28 22:34:11]

If we translate "show home button for" to Arabic or Hebrew, we should not set
dir=ltr.

   }
 
   label.reset(Value::CreateStringValue(str));
   web_ui()->CallJavascriptFunction("BrowserOptions.updateHomePageLabel",
                                    *label);
 }
 
 void BrowserOptionsHandler::Observe(
     int type,
     const content::NotificationSource& source,
@@ skipping 221 matching lines @@
   sync_status->SetBoolean("hasUnrecoverableError",
                           service->unrecoverable_error_detected());
   sync_status->SetBoolean("autoLoginVisible",
       CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableAutologin) &&
       service->AreCredentialsAvailable());
 
   return sync_status;
 }
 
 }  // namespace options2