Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2120)

Unified Diff: chrome/browser/resources/options2/browser_options.js

Issue 9513016: uber managed pref banners (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: self review 2 Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/browser_options.js
diff --git a/chrome/browser/resources/options2/browser_options.js b/chrome/browser/resources/options2/browser_options.js
index 6ab974b0938bd6b6bb8db2db53d9f98f8af7dd6e..2605ccaac14a497665a3192982186b5129765add 100644
--- a/chrome/browser/resources/options2/browser_options.js
+++ b/chrome/browser/resources/options2/browser_options.js
@@ -252,47 +252,6 @@ cr.define('options', function() {
},
/**
- * Updates managed banner visibility state. This function iterates over
- * all input fields of all subpages and if any of these is marked as managed
- * it triggers the managed banner to be visible.
- * @private
- */
- updateManagedBannerVisibility_: function() {
- var bannerDiv = $('managed-prefs-banner');
-
- var controlledByPolicy = false;
- var controlledByExtension = false;
- var inputElements = document.querySelectorAll('input[controlled-by]');
- var mainPages = document.querySelectorAll('#page-container .page');
- for (var i = 0, len = inputElements.length; i < len; i++) {
- if (inputElements[i].controlledBy == 'policy')
- controlledByPolicy = true;
- else if (inputElements[i].controlledBy == 'extension')
- controlledByExtension = true;
- }
- if (!controlledByPolicy && !controlledByExtension) {
- bannerDiv.hidden = true;
- for (var i = 0; i < mainPages.length; i++)
- mainPages[i].classList.remove('under-managed-prefs-banner');
- } else {
- bannerDiv.hidden = false;
- for (var i = 0; i < mainPages.length; i++)
- mainPages[i].classList.add('under-managed-prefs-banner');
-
- if (controlledByPolicy && !controlledByExtension) {
- $('managed-prefs-text').textContent =
- templateData.policyManagedPrefsBannerText;
- } else if (!controlledByPolicy && controlledByExtension) {
- $('managed-prefs-text').textContent =
- templateData.extensionManagedPrefsBannerText;
- } else if (controlledByPolicy && controlledByExtension) {
- $('managed-prefs-text').textContent =
- templateData.policyAndExtensionManagedPrefsBannerText;
- }
- }
- },
-
- /**
* Initializes a button for controlling screen brightness.
* @param {string} id Button ID.
* @param {string} callback Name of the callback function.
@@ -649,7 +608,6 @@ cr.define('options', function() {
'updateAutocompleteSuggestions',
'updateAutoLaunchState',
'updateHomePageLabel',
- 'updateManagedBannerVisibility',
'updateSearchEngines',
'updateSyncState',
'updateStartupPages',

Powered by Google App Engine
This is Rietveld 408576698