uber managed pref banners

uber managed pref banners

1. improve appearance (match Glen mock)
2. make them appear in overlays as appropriate
3. move below title.

BUG=114711
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124495

[Evan Stade, 2012-02-29 02:36:46]

http://codereview.chromium.org/9513016/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options_page.js (right):

http://codereview.chromium.org/9513016/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options_page.js:944:
this.pageDiv.classList.remove('showing-banner');
this became necessary after all because I moved the banner into the header, so
there's no CSS selector for it.

[Dan Beam, 2012-02-29 04:20:31]

http://codereview.chromium.org/9513016/diff/6002/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options_page.js (right):

http://codereview.chromium.org/9513016/diff/6002/chrome/browser/resources/opt...
chrome/browser/resources/options2/options_page.js:935: for (var i = 0, len =
inputElements.length; i < len; i++) {
general question, I guess, why are you caching length? tons of inputs? you've
always told me that the positives of removing property look-ups in this way are
out-weighed by the negatives.

[Dan Beam, 2012-02-29 04:20:39]

lgtm w/nit

[Tyler Breisacher (Chromium), 2012-02-29 17:27:20]

lgtm

[Evan Stade, 2012-02-29 22:34:00]

http://codereview.chromium.org/9513016/diff/6002/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options_page.js (right):

http://codereview.chromium.org/9513016/diff/6002/chrome/browser/resources/opt...
chrome/browser/resources/options2/options_page.js:935: for (var i = 0, len =
inputElements.length; i < len; i++) {
On 2012/02/29 04:20:32, Dan Beam wrote:
> general question, I guess, why are you caching length? tons of inputs? you've
> always told me that the positives of removing property look-ups in this way
are
> out-weighed by the negatives.

this code is copy pasta'd from options/ (i.e. we removed it, and now I'm
restoring it). Therefore I am not the original author. But you're right, it is
probably an overeager optimization.

[commit-bot: I haz the power, 2012-03-01 21:55:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/9513016/18002

[commit-bot: I haz the power, 2012-03-01 22:00:18]

Try job failure for 9513016-18002 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.