Switch default WM mode to managed

Switch default WM mode to managed
Don't align window to grid when restoring window.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124718

[oshima, 2012-02-29 22:02:46]

http://codereview.chromium.org/9513004/diff/19007/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_manager_unittest.cc (right):

http://codereview.chromium.org/9513004/diff/19007/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_manager_unittest.cc:305: TEST_F(WorkspaceManagerTest,
DISABLED_OpenNewWindowsMaximized) {
Just disabling for now. Let me know if it's ok to remove it.

[James Cook, 2012-02-29 22:08:26]

LGTM

[sky, 2012-02-29 22:12:49]

Can you wait until http://codereview.chromium.org/9558004/ lands so that you
don't need as many changes?

[oshima, 2012-02-29 22:16:03]

sure

On Wed, Feb 29, 2012 at 2:12 PM, <sky@chromium.org> wrote:

> Can you wait until
http://codereview.chromium.**org/9558004/<http://codereview.chromium.org/9558...
so that you
> don't need as many changes?
>
>
http://codereview.chromium.**org/9513004/<http://codereview.chromium.org/9513...
>

[oshima, 2012-02-29 23:41:42]

Scott, looks like CQ failed to land.

On 2012/02/29 22:16:03, oshima wrote:
> sure
> 
> On Wed, Feb 29, 2012 at 2:12 PM, <mailto:sky@chromium.org> wrote:
> 
> > Can you wait until
>
http://codereview.chromium.**org/9558004/%3Chttp://codereview.chromium.org/95...
> so that you
> > don't need as many changes?
> >
> >
>
http://codereview.chromium.**org/9513004/%3Chttp://codereview.chromium.org/95...>
> >

[oshima, 2012-03-01 21:47:45]

uploaded new patch. PTAL.

[sky, 2012-03-01 22:01:21]

LGTM

[James Cook, 2012-03-01 22:08:43]

lgtm

[commit-bot: I haz the power, 2012-03-01 22:22:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/9513004/23006

[oshima, 2012-03-02 00:56:55]

Scott,

Two tests in aura_shell_unittests are failing because WM adjusts the window
location to grid when opened. Is this expected?
If so, I can either change the test or disable grid in the test.
Please let me know which one you prefer. If I don't hear from you soon, I'll
change the test so that it works with grid.

[oshima, 2012-03-02 02:08:14]

Uploaded new patch. PTAL. (unit_test failure is crbug.com/116478)

On 2012/03/02 00:56:55, oshima wrote:
> Scott,
> 
> Two tests in aura_shell_unittests are failing because WM adjusts the window
> location to grid when opened. Is this expected?
> If so, I can either change the test or disable grid in the test.
> Please let me know which one you prefer. If I don't hear from you soon, I'll
> change the test so that it works with grid.

[James Cook, 2012-03-02 02:49:55]

lgtm

http://codereview.chromium.org/9513004/diff/26004/ash/wm/root_window_event_fi...
File ash/wm/root_window_event_filter_unittest.cc (right):

http://codereview.chromium.org/9513004/diff/26004/ash/wm/root_window_event_fi...
ash/wm/root_window_event_filter_unittest.cc:355: // specific locationg.
nit: locationg -> location

http://codereview.chromium.org/9513004/diff/26004/ash/wm/root_window_event_fi...
ash/wm/root_window_event_filter_unittest.cc:421: // specific locationg.
same

[oshima, 2012-03-02 03:02:50]

doh! fixed.

On 2012/03/02 02:49:55, James Cook (Chromium) wrote:
> lgtm
> 
>
http://codereview.chromium.org/9513004/diff/26004/ash/wm/root_window_event_fi...
> File ash/wm/root_window_event_filter_unittest.cc (right):
> 
>
http://codereview.chromium.org/9513004/diff/26004/ash/wm/root_window_event_fi...
> ash/wm/root_window_event_filter_unittest.cc:355: // specific locationg.
> nit: locationg -> location
> 
>
http://codereview.chromium.org/9513004/diff/26004/ash/wm/root_window_event_fi...
> ash/wm/root_window_event_filter_unittest.cc:421: // specific locationg.
> same

[commit-bot: I haz the power, 2012-03-02 18:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/9513004/24011

[oshima, 2012-03-02 18:34:16]

Just for the record. I got lgtm from sky offline.


On 2012/03/02 18:31:45, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/oshima%40chromium.org/9513004/24011

[commit-bot: I haz the power, 2012-03-02 20:17:46]

Change committed as 124718