Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 9508008: Allow apps with background pages to request process-per-app-instance. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up tests. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_manifests_unittest.cc
diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc
index ccc921031d496ed89939d926b3d2df33cc2378a3..6ba645035be31881d6007d953fcc35388d18df9a 100644
--- a/chrome/common/extensions/extension_manifests_unittest.cc
+++ b/chrome/common/extensions/extension_manifests_unittest.cc
@@ -987,6 +987,7 @@ TEST_F(ExtensionManifestTest, BackgroundPage) {
LoadAndExpectSuccess("background_page.json"));
ASSERT_TRUE(extension);
EXPECT_EQ("/foo.html", extension->GetBackgroundURL().path());
+ EXPECT_TRUE(extension->allow_background_js_access());
std::string error;
scoped_ptr<DictionaryValue> manifest(
@@ -1027,6 +1028,13 @@ TEST_F(ExtensionManifestTest, BackgroundScripts) {
errors::kInvalidBackgroundCombination);
}
+TEST_F(ExtensionManifestTest, BackgroundAllowNoJsAccess) {
+ scoped_refptr<Extension> extension;
+ extension = LoadAndExpectSuccess("background_allow_no_js_access.json");
+ ASSERT_TRUE(extension);
+ EXPECT_FALSE(extension->allow_background_js_access());
+}
+
TEST_F(ExtensionManifestTest, PageActionManifestVersion2) {
scoped_refptr<Extension> extension(
LoadAndExpectSuccess("page_action_manifest_version_2.json"));

Powered by Google App Engine
This is Rietveld 408576698