Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/common/extensions/extension.h

Issue 9508008: Allow apps with background pages to request process-per-app-instance. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up tests. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index f95cf18ccb55d958f634d6f881c15233c623c5f8..b844bcf3f6910d02fc86a477deb9e83ed991edd7 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -556,6 +556,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool has_background_page() const {
return background_url_.is_valid() || !background_scripts_.empty();
}
+ bool allow_background_js_access() const {
+ return allow_background_js_access_;
+ }
const std::vector<std::string>& background_scripts() const {
return background_scripts_;
}
@@ -689,6 +692,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadBackgroundPersistent(
const ExtensionAPIPermissionSet& api_permissions,
string16* error);
+ bool LoadBackgroundAllowJsAccess(
+ const ExtensionAPIPermissionSet& api_permissions,
+ string16* error);
// Helper method that loads a UserScript object from a
// dictionary in the content_script list of the manifest.
@@ -842,6 +848,12 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// load on-demand (when it needs to handle an event). Defaults to true.
bool background_page_persists_;
+ // True if the background page can be scripted by pages of the app or
+ // extension, in which case all such pages must run in the same process.
+ // False if such pages are not permitted to script the background page,
+ // allowing them to run in different processes.
+ bool allow_background_js_access_;
+
// Optional URL to a page for setting options/preferences.
GURL options_url_;
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698