Make chroot setup work better with NFS home dirs.

Make chroot setup work better with NFS home dirs.


BUG=none
TEST=install-chroot.sh works on Google corp machines.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124265

[Markus (顧孟勤), 2012-02-29 18:45:54]

lgtm

I still think, we probably need to offer some option for bind-mounting the rest
of the regular (i.e. local or NFS) file systems. But that might be out of scope
for this particular change list. I can take a look later today and see if I can
come up with a solution that works for the majority of users.

https://chromiumcodereview.appspot.com/9500022/diff/1/build/install-chroot.sh
File build/install-chroot.sh (right):

https://chromiumcodereview.appspot.com/9500022/diff/1/build/install-chroot.sh...
build/install-chroot.sh:206: sed '\,^/home[/[:space:]],s/,bind/,rbind/'
/etc/schroot/mount-defaults |
I am a little worried that there might be versions of "sed" that don't support
character classes. But maybe I am too old fashioned. This might in fact be
perfectly fine.

Also, we are probably OK with matching the comma before the "bind", but if you
want to be extra careful, match either a comma or white-space. Probably, do the
same at the end of the string, too.

[commit-bot: I haz the power, 2012-02-29 20:04:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmoss@chromium.org/9500022/4001

[commit-bot: I haz the power, 2012-02-29 22:08:49]

Change committed as 124265