Pass DefaultDeviceScaleFactor to webkit

Pass DefaultDeviceScaleFactor to webkit

DefaultDeviceScaleFactor will be based solely on the screen DPI, as opposed to DeviceScaleFactor,
which incorporates information from the viewport tag.

This is a follow-up to: https://bugs.webkit.org/show_bug.cgi?id=79534

BUG=115231
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124411

[Fady Samuel, 2012-02-29 15:42:25]

Tim, there's code in RenderViewImpl's constructor that's redundant now that
you're taking this approach. Could you please get rid of code in this patch? In
RenderViewImpl, we can read the defaultDevieScaleFactor from prefs/settings now,
rather than doing this in the constructor, and storing it in a member variable.
Thanks.

https://chromiumcodereview.appspot.com/9500015/diff/4002/content/browser/tab_...
File content/browser/tab_contents/tab_contents.cc (right):

https://chromiumcodereview.appspot.com/9500015/diff/4002/content/browser/tab_...
content/browser/tab_contents/tab_contents.cc:466: if
(default_device_scale_factor)
This if statement is probably not necessary. We can just ignore a
defaultDeviceScaleFactor of 0 in RenderViewImpl.

[tdresser, 2012-02-29 16:51:30]

https://chromiumcodereview.appspot.com/9500015/diff/4002/content/browser/tab_...
File content/browser/tab_contents/tab_contents.cc (right):

https://chromiumcodereview.appspot.com/9500015/diff/4002/content/browser/tab_...
content/browser/tab_contents/tab_contents.cc:466: if
(default_device_scale_factor)
On 2012/02/29 15:42:25, Fady Samuel wrote:
> This if statement is probably not necessary. We can just ignore a
> defaultDeviceScaleFactor of 0 in RenderViewImpl.

Done.

[Fady Samuel, 2012-02-29 16:55:16]

Sweet thanks! Sorry, one more thing before I forget, could you please get rid of
kDefaultDeviceScaleFactor in
content/browser/renderer_host/render_process_host_impl.cc?

This passes the command line parameter to the forked renderer process. Because
we're passing this as an IPC now, we don't need to pass the command line
parameter. Might as well get rid of it to avoid cruft.

On 2012/02/29 16:51:30, tdresser wrote:
>
https://chromiumcodereview.appspot.com/9500015/diff/4002/content/browser/tab_...
> File content/browser/tab_contents/tab_contents.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9500015/diff/4002/content/browser/tab_...
> content/browser/tab_contents/tab_contents.cc:466: if
> (default_device_scale_factor)
> On 2012/02/29 15:42:25, Fady Samuel wrote:
> > This if statement is probably not necessary. We can just ignore a
> > defaultDeviceScaleFactor of 0 in RenderViewImpl.
> 
> Done.

[Fady Samuel, 2012-02-29 18:17:35]

On 2012/02/29 18:09:36, tdresser wrote:

lgtm. Darin, could you please have a look as an OWNER? Thanks :)

[darin (slow to review), 2012-02-29 22:15:06]

LGTM

http://codereview.chromium.org/9500015/diff/4005/content/browser/tab_contents...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/9500015/diff/4005/content/browser/tab_contents...
content/browser/tab_contents/tab_contents.cc:463:
switches::kDefaultDeviceScaleFactor),
nit: indent parameter to GetSwitchValueASCII so it doesn't look like it is a
parameter to StringToInt.

[tdresser, 2012-03-01 14:05:11]

http://codereview.chromium.org/9500015/diff/4005/content/browser/tab_contents...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/9500015/diff/4005/content/browser/tab_contents...
content/browser/tab_contents/tab_contents.cc:463:
switches::kDefaultDeviceScaleFactor),
On 2012/02/29 22:15:06, darin wrote:
> nit: indent parameter to GetSwitchValueASCII so it doesn't look like it is a
> parameter to StringToInt.

Done.

[commit-bot: I haz the power, 2012-03-01 14:05:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tdresser@chromium.org/9500015/12001

[commit-bot: I haz the power, 2012-03-01 15:40:12]

Change committed as 124411