Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 9500007: Views: Update ImageLoadingTracker::Observer subclasses (Closed)

Created:
8 years, 9 months ago by sail
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, Mihai Parparita -not on Chrome, Finnur
Visibility:
Public.

Description

Views: Update ImageLoadingTracker::Observer subclasses BUG=112651 TEST=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -49 lines) Patch
M chrome/browser/ui/views/aura/app_list/extension_app_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/aura/app_list/extension_app_item.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/aura/launcher/chrome_launcher_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/aura/launcher/chrome_launcher_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/aura/launcher/launcher_icon_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 4 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 2 chunks +9 lines, -10 lines 1 comment Download
M chrome/browser/ui/views/location_bar/page_action_image_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sail
This is the Views portion of the multiple icon size CL (http://codereview.chromium.org/9428025/)
8 years, 9 months ago (2012-02-29 06:00:55 UTC) #1
sky
https://chromiumcodereview.appspot.com/9500007/diff/1/chrome/browser/ui/views/infobars/extension_infobar.cc File chrome/browser/ui/views/infobars/extension_infobar.cc (left): https://chromiumcodereview.appspot.com/9500007/diff/1/chrome/browser/ui/views/infobars/extension_infobar.cc#oldcode96 chrome/browser/ui/views/infobars/extension_infobar.cc:96: if (!icon_resource.relative_path().empty()) { Did you remove this because ImageTracker ...
8 years, 9 months ago (2012-02-29 15:44:05 UTC) #2
sail
On 2012/02/29 15:44:05, sky wrote: > https://chromiumcodereview.appspot.com/9500007/diff/1/chrome/browser/ui/views/infobars/extension_infobar.cc > File chrome/browser/ui/views/infobars/extension_infobar.cc (left): > > https://chromiumcodereview.appspot.com/9500007/diff/1/chrome/browser/ui/views/infobars/extension_infobar.cc#oldcode96 > ...
8 years, 9 months ago (2012-02-29 19:19:28 UTC) #3
sky
8 years, 9 months ago (2012-02-29 21:47:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698