Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 9494007: Upstream test sharder. (Closed)

Created:
8 years, 9 months ago by bulach
Modified:
8 years, 9 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews
Visibility:
Public.

Description

Upstream test sharder. On chromium for android, we shard tests by splitting the set of tests and running on multiple connected devices. BUG= TEST=build/android/run_tests.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124214

Patch Set 1 : N emulators launched asynchronously #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -52 lines) Patch
M build/android/base_test_runner.py View 2 chunks +23 lines, -7 lines 0 comments Download
A build/android/base_test_sharder.py View 1 chunk +108 lines, -0 lines 0 comments Download
M build/android/emulator.py View 3 chunks +6 lines, -5 lines 0 comments Download
M build/android/run_tests.py View 9 chunks +90 lines, -22 lines 0 comments Download
M build/android/single_test_runner.py View 5 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
hey john, here's the test sharder. there are two aspects of this change: 1. upstreaming ...
8 years, 9 months ago (2012-02-28 17:25:47 UTC) #1
John Grabowski
LGTM to all of this but... Can you send this through the android_try bot first? ...
8 years, 9 months ago (2012-02-28 23:59:27 UTC) #2
bulach
bots are trying now. I smoked in my local build with both multiple devices, and ...
8 years, 9 months ago (2012-02-29 11:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/9494007/3001
8 years, 9 months ago (2012-02-29 15:45:43 UTC) #4
commit-bot: I haz the power
Change committed as 124214
8 years, 9 months ago (2012-02-29 18:40:29 UTC) #5
John Grabowski
8 years, 9 months ago (2012-02-29 19:52:30 UTC) #6
In attempts at fixing emulator tests, I did things like
- changed the emulator to stop/start for each test bundle
- completely wipe the emulator image on each test bundle run (!!)

So don't worry about the super-suck.

jrg

On Wed, Feb 29, 2012 at 3:40 AM, <bulach@chromium.org> wrote:

> bots are trying now.
> I smoked in my local build with both multiple devices, and also multiple
> emulators (emulators don't scale too well for base and other small-ish
> tests,
> the emulator startup dominates the time..).
>
>
https://chromiumcodereview.**appspot.com/9494007/<https://chromiumcodereview....
>

Powered by Google App Engine
This is Rietveld 408576698