Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 9491007: Added test for disallowed tcp server socket API. (Closed)

Created:
8 years, 9 months ago by ygorshenin1
Modified:
8 years, 9 months ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews, Dmitry Polukhin
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added test for disallowed tcp server socket API. BUG= TEST=PPAPINaClTestDisallowedSockets.TCPServerSocketPrivateDisallowed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126068

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sync, added initialization of Core interface. #

Patch Set 3 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/tests/test_tcp_server_socket_private_disallowed.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ppapi/tests/test_tcp_server_socket_private_disallowed.cc View 1 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ygorshenin1
8 years, 9 months ago (2012-02-28 13:04:13 UTC) #1
yzshen1
lgtm http://codereview.chromium.org/9491007/diff/1/ppapi/tests/test_tcp_server_socket_private_disallowed.cc File ppapi/tests/test_tcp_server_socket_private_disallowed.cc (right): http://codereview.chromium.org/9491007/diff/1/ppapi/tests/test_tcp_server_socket_private_disallowed.cc#newcode25 ppapi/tests/test_tcp_server_socket_private_disallowed.cc:25: : TestCase(instance), tcp_server_socket_private_interface_(NULL) { Please also init core_interface_
8 years, 9 months ago (2012-02-29 19:21:09 UTC) #2
ygorshenin1
Thanks. http://codereview.chromium.org/9491007/diff/1/ppapi/tests/test_tcp_server_socket_private_disallowed.cc File ppapi/tests/test_tcp_server_socket_private_disallowed.cc (right): http://codereview.chromium.org/9491007/diff/1/ppapi/tests/test_tcp_server_socket_private_disallowed.cc#newcode25 ppapi/tests/test_tcp_server_socket_private_disallowed.cc:25: : TestCase(instance), tcp_server_socket_private_interface_(NULL) { On 2012/02/29 19:21:09, yzshen1 ...
8 years, 9 months ago (2012-03-01 08:09:41 UTC) #3
ygorshenin1
Friendly ping.
8 years, 9 months ago (2012-03-07 11:27:56 UTC) #4
brettw
LGTM. Sorry, I thought Yuzhu's review was good enough.
8 years, 9 months ago (2012-03-08 05:41:04 UTC) #5
ygorshenin1
Thanks!
8 years, 9 months ago (2012-03-11 08:32:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/9491007/13001
8 years, 9 months ago (2012-03-11 08:33:17 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-11 11:07:13 UTC) #8
Change committed as 126068

Powered by Google App Engine
This is Rietveld 408576698