Elide long emails in the wrench and profile menus.

ui/base/text/text_elider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines utility functions for eliding and formatting UI text.
 
 #ifndef UI_BASE_TEXT_TEXT_ELIDER_H_
 #define UI_BASE_TEXT_TEXT_ELIDER_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/string16.h"
 #include "ui/base/ui_export.h"
 #include "ui/gfx/font.h"
 #include "unicode/coll.h"
 #include "unicode/uchar.h"
 
 class FilePath;
 class GURL;
 
 namespace ui {
 
 UI_EXPORT extern const char kEllipsis[];
+UI_EXPORT extern const size_t kMaxProfileUsernameLength;

[Alexei Svitkine (slow), 2012/02/28 15:46:22]

This is the wrong place for such a constant. ui/base/... shouldn't know anything
about profiles.

[gab, 2012/02/28 19:20:11]

Right, I didn't know where to put this as the reverse is also true: profiles
shouldn't know anything about ui.

Any suggestions on where to put it?

On 2012/02/28 15:46:22, Alexei Svitkine wrote:

 
 // This function takes a GURL object and elides it. It returns a string
 // which composed of parts from subdomain, domain, path, filename and query.
 // A "..." is added automatically at the end if the elided string is bigger
 // than the available pixel width. For available pixel width = 0, empty
 // string is returned. |languages| is a comma separted list of ISO 639
 // language codes and is used to determine what characters are understood
 // by a user. It should come from |prefs::kAcceptLanguages|.
 //
 // Note: in RTL locales, if the URL returned by this function is going to be
 // displayed in the UI, then it is likely that the string needs to be marked
 // as an LTR string (using base::i18n::WrapStringWithLTRFormatting()) so that it
 // is displayed properly in an RTL context. Please refer to
 // http://crbug.com/6487 for more information.
 UI_EXPORT string16 ElideUrl(const GURL& url,
                             const gfx::Font& font,
                             int available_pixel_width,
                             const std::string& languages);
 
+// Elides only the username portion of the email, if possible, so that the
+// overall email is at most max_email_length characters (e.g.

[Alexei Svitkine (slow), 2012/02/28 15:46:22]

Please variables parameter names in comments with |'s. i.e. |max_email_length|

+// longusername@host.com --> longuser...@host.com for max_email_length == 20).
+// If the domain name by itself already has more characters than available,
+// we elide the domain name in the middle so that only max_email_length / 2

[Alexei Svitkine (slow), 2012/02/28 15:46:22]

Nit: Please rephrase in a way that avoids using "we". For example:

If the domain name already has more characters than available, it is elided in
the middle ...

+// characters remain. We then proceed with the regular eliding described above.
+// In any scenario: the string returned will never be longer than
+// max_email_length including the inserted ellipses; and the elided strings
+// will have at least one character remaining on either side of the '@'(other
+// than the ellipsis-es).
+// This function assumes max_email_length is >= 5.
+UI_EXPORT string16 ElideEmail(const string16& email,
+                              size_t max_email_length);

[sail, 2012/02/28 18:37:20]

Eliding using character length is incorrect. Eliding should be based on pixel
width instead. See: 
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/cocoa/boo...

If you make this change then I think you should move the eliding out of
AvatarMenuModel and into the various platform specific functions.

+
 enum ElideBehavior {
   // Add ellipsis at the end of the string.
   ELIDE_AT_END,
   // Add ellipsis in the middle of the string.
   ELIDE_IN_MIDDLE,
   // Truncate the end of the string.
   TRUNCATE_AT_END
 };
 
 // Elides |text| to fit in |available_pixel_width| according to the specified
@@ skipping 113 matching lines @@
 // Truncates the string to length characters. This breaks the string at
 // the first word break before length, adding the horizontal ellipsis
 // character (unicode character 0x2026) to render ...
 // The supplied string is returned if the string has length characters or
 // less.
 UI_EXPORT string16 TruncateString(const string16& string, size_t length);
 
 }  // namespace ui
 
 #endif  // UI_BASE_TEXT_TEXT_ELIDER_H_