Elide long emails in the wrench and profile menus.

ui/base/text/text_elider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file implements utility functions for eliding and formatting UI text.
 //
 // Note that several of the functions declared in text_elider.h are implemented
 // in this file using helper classes in the anonymous namespace.
 
 #include "ui/base/text/text_elider.h"
@@ skipping 131 matching lines @@
     if (available_pixel_width >= font.GetStringWidth(elided_path))
       return ElideText(elided_path + url_query,
                        font, available_pixel_width, ELIDE_AT_END);
   }
 
   return string16();
 }
 
 }  // namespace
 
-// This function takes a GURL object and elides it. It returns a string
-// which composed of parts from subdomain, domain, path, filename and query.
-// A "..." is added automatically at the end if the elided string is bigger
-// than the available pixel width. For available pixel width = 0, a formatted,
-// but un-elided, string is returned.
-//
+string16 ElideEmail(const string16& email,
+                    const gfx::Font& font,
+                    int available_pixel_width) {
+  if (font.GetStringWidth(email) <= available_pixel_width)
+    return email;
+
+  std::vector<string16> email_split;
+  base::SplitString(email, '@', &email_split);
+  DCHECK_EQ(email_split.size(), 2U);
+  string16 username = email_split.front();
+  string16 domain = email_split.back();
+
+  const string16 kEllipsisUTF16 = UTF8ToUTF16(kEllipsis);
+
+  // Ignore the @ symbol and add it back at the end.

[asvitkine_google, 2012/03/01 22:10:56]

Nit: Can you reword this better? The second part of the comment isn't relevant
here since this deals with measurement of the widths rather than the
construction of the final string.

+  const string16 kAtSignUTF16 = ASCIIToUTF16("@");
+  available_pixel_width -= font.GetStringWidth(kAtSignUTF16);
+
+  // Check whether eliding the domain is necessary: if eliding the username
+  // is sufficient, the domain will not be elided.
+  const int available_domain_width =
+      available_pixel_width -
+      font.GetStringWidth(username.substr(0, 1) + kEllipsisUTF16);
+  const int full_username_width = font.GetStringWidth(username);
+  if (font.GetStringWidth(domain) > available_domain_width) {
+    // Elide the domain so that it only takes half of the available width.
+    // Should the username not need all the width available in the other half,
+    // let the domain take that extra space.

[asvitkine_google, 2012/03/01 22:10:56]

If the username is short, shouldn't you elide the domain to the maximum width it
can take in that case?

[gab, 2012/03/01 23:03:46]

Yes, this is exactly what this does. I reworded the comment to make this more
obvious, let me know if it's better.

Verbosely: if the domain must be elided: give half the width to the domain and
the other half to the username. If the username doesn't need all of its half
(i.e. the non-elided version is not even that wide), the domain takes the extra
width by being elided to fit a bigger width.

+    const int desired_domain_width =
+        std::max(available_pixel_width - full_username_width,
+                 available_pixel_width / 2);
+    domain = ElideText(domain, font, desired_domain_width, ELIDE_IN_MIDDLE);
+    if (domain.length() <= 1U)
+      return kEllipsisUTF16;
+  }
+
+  const int final_domain_width = font.GetStringWidth(domain);

[asvitkine_google, 2012/03/01 22:10:56]

Nit: How about:

available_pixel_width -= font.GetStringWidth(domain);

and then not needing to use final_domain_width below.

[gab, 2012/03/01 23:03:46]

I like that :)!

+  if (full_username_width + final_domain_width > available_pixel_width) {
+    username = ElideText(username,
+                         font,
+                         available_pixel_width - final_domain_width,
+                         ELIDE_AT_END);
+    if (username.length() <= 1U)
+      return kEllipsisUTF16;
+  }
+
+  return username + kAtSignUTF16 + domain;
+}
+
 // TODO(pkasting): http://crbug.com/77883 This whole function gets
 // kerning/ligatures/etc. issues potentially wrong by assuming that the width of
 // a rendered string is always the sum of the widths of its substrings.  Also I
 // suspect it could be made simpler.
 string16 ElideUrl(const GURL& url,
                   const gfx::Font& font,
                   int available_pixel_width,
                   const std::string& languages) {
   // Get a formatted string and corresponding parsing of the url.
   url_parse::Parsed parsed;
@@ skipping 218 matching lines @@
     return base::i18n::GetDisplayStringInLTRDirectionality(elided_name);
   }
 
   int available_root_width = available_pixel_width - ext_width;
   string16 elided_name =
       ElideText(rootname, font, available_root_width, ELIDE_AT_END);
   elided_name += extension;
   return base::i18n::GetDisplayStringInLTRDirectionality(elided_name);
 }
 
-// This function adds an ellipsis at the end of the text if the text
-// does not fit the given pixel width.
 string16 ElideText(const string16& text,
                    const gfx::Font& font,
                    int available_pixel_width,
                    ElideBehavior elide_behavior) {
   if (text.empty())
     return text;
 
   const string16 kEllipsisUTF16 = UTF8ToUTF16(kEllipsis);
 
   const int current_text_pixel_width = font.GetStringWidth(text);
@@ skipping 653 matching lines @@
       index = char_iterator.getIndex();
     } else {
       // String has leading whitespace, return the elide string.
       return kElideString;
     }
   }
   return string.substr(0, index) + kElideString;
 }
 
 }  // namespace ui