aura: Fix popup window positioning.

aura: Fix popup window positioning.

RenderWidgetHostViewAura::SetBounds() is called from RenderWidgetHostViewAura::InitAsChild() with 
|popup_parent_host_view_|'s coordinates. But it's called from Webkit directly with root window coordinates.

When popup window is repositioned (for example, when the number of auto-complete list is changed), SetBounds() is called directly and the window moves in the wrong place.

BUG=115063
TEST=Checks auto-complete list and dropdown menu of combobox are placed in the correct position, and pass trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124384

[yoshiki, 2012-02-28 09:09:17]

detat, sadrul: Could you take a look? Because you had changed around the code
modified in this CL.

[Daniel Erat, 2012-02-28 17:41:03]

lgtm

http://codereview.chromium.org/9489003/diff/4002/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/9489003/diff/4002/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:177:
SetBounds(gfx::Rect(pos.origin(), pos.size()));
why are you creating a new gfx::Rect here instead of just passing |pos|?

also, it's probably better to set the bounds before calling Show(), assuming
there aren't any issues with doing that.

[tfarina, 2012-02-28 18:08:30]

http://codereview.chromium.org/9489003/diff/4002/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/9489003/diff/4002/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:177:
SetBounds(gfx::Rect(pos.origin(), pos.size()));
if |pos| is-a gfx::Rect, why are you creating another rect, instead of passing
|pos| directly to SetBounds?

[commit-bot: I haz the power, 2012-02-29 08:37:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/9489003/9001

[commit-bot: I haz the power, 2012-02-29 08:37:05]

Presubmit check for 9489003-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/renderer_host/render_widget_host_view_aura.cc

[yoshiki, 2012-02-29 08:37:28]

Thank you for review! Will commit it.

https://chromiumcodereview.appspot.com/9489003/diff/4002/content/browser/rend...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://chromiumcodereview.appspot.com/9489003/diff/4002/content/browser/rend...
content/browser/renderer_host/render_widget_host_view_aura.cc:177:
SetBounds(gfx::Rect(pos.origin(), pos.size()));
On 2012/02/28 18:08:30, tfarina wrote:
> if |pos| is-a gfx::Rect, why are you creating another rect, instead of passing
> |pos| directly to SetBounds?

Done.

[yoshiki, 2012-02-29 08:43:04]

ben: Could you take a look and give an approval?

[Ben Goodger (Google), 2012-02-29 16:25:36]

lgtm

[tfarina, 2012-02-29 16:35:59]

https://chromiumcodereview.appspot.com/9489003/diff/9001/content/browser/rend...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://chromiumcodereview.appspot.com/9489003/diff/9001/content/browser/rend...
content/browser/renderer_host/render_widget_host_view_aura.cc:210:
window_->SetBounds(adjusted_rect);
nit: you don't need the temp here too. Just do:
window_->SetBounds(rect);

[yoshiki, 2012-03-01 03:05:09]

ben, tfarina: thanks!

http://codereview.chromium.org/9489003/diff/9001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/9489003/diff/9001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:210:
window_->SetBounds(adjusted_rect);
On 2012/02/29 16:35:59, tfarina wrote:
> nit: you don't need the temp here too. Just do:
> window_->SetBounds(rect);

Done.

[commit-bot: I haz the power, 2012-03-01 03:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/9489003/14001

[commit-bot: I haz the power, 2012-03-01 07:52:35]

Change committed as 124384